This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
Separate DLNA_DMR and DLNA_DMS devices #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
approved these changes
Aug 7, 2018
|
Thanks! ok to merge when lint addressed and PR for Home Assistant created 👍 |
balloob
approved these changes
Aug 7, 2018
Merged
2 tasks
balloob
approved these changes
Aug 8, 2018
|
Released as netdisco 2.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DLNA standard specifies four device types (see the Wikipedia page on DLNA):
At this moment netdisco discovers DMS and DMR devices as one, named DLNA.
Currently, Home Assistant is - as far as I know - only interested in DMR devices (as per home-assistant/core#14749). The component in home-assistant now needs to detect if the device is a DMR device.
If these device types are separated, home-assistant becomes less 'polluted' with checks for proper device types. Also, introducing a DMS component to home-assistant would not work with discovery, as the DLNA_DMR component already 'catches' the DLNA discoveries.
Also, there are 4 DMS and 3 DMR versions. Currently only version 1 of both is discovered. This pull request makes netdisco support the other versions.
Please do inform me before merging (and releasing) this! The DLNA_DMR component in home-assistant + discovery has to be updated as well.