Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pygobject dependency #5

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Drop pygobject dependency #5

merged 1 commit into from
Feb 14, 2023

Conversation

agners
Copy link
Collaborator

@agners agners commented Feb 14, 2023

It is no longer required since for BlueZ communication the C++ API is used.

It is no longer required since for BlueZ communication the C++ API
is used.
@agners
Copy link
Collaborator Author

agners commented Feb 14, 2023

It seems this dependency is to connect to BlueZ via D-Bus in Python. But python-dbus has been dropped as dependency upstream in project-chip/connectedhomeip#23564. That does seem wrong, since chip/ChipBluezMgr.py and chip-device-ctrl.py still connects to BlueZ directly, but that is not used by the core chip code, and also not by our server. So for our case, we can definitely drop that.

As for upstream, chip/ChipBluezMgr.py and chip-device-ctrl.py is shipped as part of the chip-core wheel. Ideally, we should move this to a separate package, maybe into the REPL package.

@agners
Copy link
Collaborator Author

agners commented Feb 14, 2023

Tested this builds using WS, I can still pair a device using BLE, which proves that pygobject is indeed not necessary.

@agners agners merged commit 118249e into main Feb 14, 2023
@agners agners deleted the drop-pygobject-dependency branch February 14, 2023 15:22
@agners
Copy link
Collaborator Author

agners commented Feb 14, 2023

As for upstream, chip/ChipBluezMgr.py and chip-device-ctrl.py is shipped as part of the chip-core wheel. Ideally, we should move this to a separate package, maybe into the REPL package.

Implemented with project-chip/connectedhomeip#25055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants