Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass storage_options to pandas.to_parquet. Update docs/CHANGELOG #79

Merged
merged 47 commits into from
Aug 6, 2021
Merged

Add ability to pass storage_options to pandas.to_parquet. Update docs/CHANGELOG #79

merged 47 commits into from
Aug 6, 2021

Conversation

iameskild
Copy link
Contributor

@iameskild iameskild commented Aug 5, 2021 •
edited
Loading

Questions:

  • Do we want to include docstrings for _retry_args (pack_partitions_to_parquet)?
    • Answer: Swap out retrying with tenacity in another PR.
  • Do we want to pass storage_options to pandas.to_parquet call?

@iameskild iameskild closed this Aug 5, 2021
@iameskild iameskild reopened this Aug 5, 2021
@iameskild iameskild changed the title Update docstrings, CHANGELOG and other minor changes. Add ability to pass storage_options to pandas.to_parquet. Update docs/CHANGELOG Aug 6, 2021
@brl0 brl0 mentioned this pull request Aug 6, 2021
Merged
jbednar
jbednar approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
spatialpandas/io/__init__.py Outdated Show resolved Hide resolved
brl0
brl0 reviewed Aug 6, 2021
View reviewed changes
spatialpandas/io/parquet.py Outdated Show resolved Hide resolved
@brl0 brl0 merged commit db730b6 into holoviz:master Aug 6, 2021
@iameskild iameskild mentioned this pull request Aug 16, 2021
Closed
@iameskild iameskild deleted the fix/dask_parquet branch February 19, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brl0 brl0 brl0 left review comments

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iameskild @jbednar @brl0