Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check hook signature #7502

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Explicitly check hook signature #7502

merged 1 commit into from
Nov 18, 2024

Conversation

philippjfr
Copy link
Member

Ensure we do not mask hook errors (as seen in #7438) due to handling hook signature fallback using try/except.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (b597638) to head (a24dac7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7502   +/-   ##
=======================================
  Coverage   82.37%   82.38%           
=======================================
  Files         339      339           
  Lines       50995    50995           
=======================================
+ Hits        42008    42011    +3     
+ Misses       8987     8984    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@philippjfr philippjfr merged commit 951f620 into main Nov 18, 2024
18 checks passed
@philippjfr philippjfr deleted the hook_signature_fix branch November 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant