Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hold docs #7500

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Improve hold docs #7500

merged 2 commits into from
Nov 18, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Nov 18, 2024

When trying the new hold docs with pyodide run button, I found it confusing that the first button updated the second column.

This PR fixes this issue, makes it more clear what happens without hold with an example, and improves the spelling.

@philippjfr philippjfr merged commit 8421976 into main Nov 18, 2024
11 checks passed
@philippjfr philippjfr deleted the enhancement/hold branch November 18, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants