Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue collecting compile bundles #7477

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Fix issue collecting compile bundles #7477

merged 3 commits into from
Nov 11, 2024

Conversation

philippjfr
Copy link
Member

Fix inverted logic and add basic test.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.38%. Comparing base (cf9dc6b) to head (9b48712).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/command/compile.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7477      +/-   ##
==========================================
+ Coverage   82.36%   82.38%   +0.01%     
==========================================
  Files         338      339       +1     
  Lines       50964    50980      +16     
==========================================
+ Hits        41977    41999      +22     
+ Misses       8987     8981       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit bddcf35 into main Nov 11, 2024
17 checks passed
@philippjfr philippjfr deleted the compile_fix branch November 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant