Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7380: Preview Panel with notifications enabled #7466

Conversation

MP-MaximilianLattka
Copy link
Contributor

- Fixes regression bug: holoviz#7380
- Reverts change from 15a8241
- `os.fspath` does not accept `None`
panel/io/resources.py Outdated Show resolved Hide resolved
panel/io/resources.py Outdated Show resolved Hide resolved
panel/io/resources.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (6c322c5) to head (6c7b37e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/resources.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7466      +/-   ##
==========================================
+ Coverage   82.30%   82.31%   +0.01%     
==========================================
  Files         338      338              
  Lines       50838    50896      +58     
==========================================
+ Hits        41840    41893      +53     
- Misses       8998     9003       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit bfc5859 into holoviz:main Nov 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants