Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator aggregators: allow nested dict, fix data aggregation #7450

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

thuydotm
Copy link
Collaborator

@thuydotm thuydotm commented Oct 29, 2024

Fixes #7281 and partially #7449

TODO:

  • add tests
  • add docs for nested aggs

TODO LATER in other PRs:

  • validate input aggs?
  • for columns with no agg method, set NaNs to them? Needs a bit more experiment to see what we should do
  • display the indexes properly

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 38.98305% with 72 lines in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (8dd362f) to head (d08363e).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 38.46% 72 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7450      +/-   ##
==========================================
+ Coverage   82.08%   82.27%   +0.19%     
==========================================
  Files         337      339       +2     
  Lines       50680    51112     +432     
==========================================
+ Hits        41599    42052     +453     
+ Misses       9081     9060      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@philippjfr
Copy link
Member

Great! Some tests would be good.

@maximlt maximlt marked this pull request as draft October 29, 2024 12:48
@thuydotm thuydotm marked this pull request as ready for review November 11, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator: Separate aggregators for different columns blocked by type hint
2 participants