-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align JSON and CodeEditor default theme with overall theme #7406
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7406 +/- ##
=======================================
Coverage 82.23% 82.23%
=======================================
Files 337 337
Lines 50557 50601 +44
=======================================
+ Hits 41576 41614 +38
- Misses 8981 8987 +6 ☔ View full report in Codecov by Sentry. |
When you review please consider it as a concept for theming that can be extended to matplotlib, Plotly and other components. |
Its probably also worth considering whether this should be handled in the frontend to enable saved apps to be able to handle themes. As a minimum the API should be something we could convert to a frontend implementation one day. |
Closing #7394.
Looks like below
Default
Dark
Script
You can use the below to select the appropriate dark theme for the CodeEditor.