fix: wrong offset when memoryview format is non-byte #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the offset should be in bytes, not elements. See also bokeh/ipywidgets_bokeh#46 (comment)
|
Thanks! That looks good to me. |
Codecov Report
@@ Coverage Diff @@
## master #3206 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 193 193
Lines 25695 25695
=======================================
Hits 21367 21367
Misses 4328 4328
Continue to review full report at Codecov.
|
|
Thanks @maartenbreddels, really appreciate it! |
philippjfr
pushed a commit
that referenced
this pull request
Mar 26, 2022
the offset should be in bytes, not elements. See also bokeh/ipywidgets_bokeh#46 (comment)
philippjfr
added a commit
that referenced
this pull request
Mar 27, 2022
* Fix jinja2 imports (#3258) * fix: wrong offset when memoryview format is non-byte (#3206) the offset should be in bytes, not elements. See also bokeh/ipywidgets_bokeh#46 (comment) * Support jupyter server root_dir with lab extension (#3172) Jupyter sends path relative to the root_dir which can be different from the cwd. This commit fixes the lab extension for panel preview to account for root_dir. Reference: #3170 * DOC: add note on enabling panel widget on Jupyter Lab (#3029) * Remove redundant and confusing JupyterLab install instructions (#3037) * Remove reference to Python 2 and link to Travis * Remove redondant install instructions to work with Jupyter * Update CHANGELOG * Add setuptools to build requirements * use https instead of the git:// protocol in GHA (#3092) * Try to switch to setuptools (#3138) * Try to switch to setuptools * Continue on error * CI: fix Macos tests workflow (#3160) * attempt to fix CI on macos * forgot bokeh channel * remove strict setting * reset strict and add pyctdev channel * remove continue_on_error and test py310 * clean up test workflow * add comment about PYCTDEV_SELF_CHANNEL * remove py310 * Revert change to build backend * Update setuptools pin * Pin setuptools * Further pin updates * Pin setuptools (#3265) * Fix image_url test * Pin pyvista * Bump panel.js version * Fix GH workflows * Bump panel.js version Co-authored-by: Maarten Breddels <[email protected]> Co-authored-by: Govinda Totla <[email protected]> Co-authored-by: Ray Bell <[email protected]> Co-authored-by: Maxime Liquet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the offset should be in bytes, not elements. See also bokeh/ipywidgets_bokeh#46 (comment)