-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include by default a HoloViz dropdown in the primary sidebar with links to all the HoloViz sites #319
Conversation
Maybe move it to the right sidebar if it is available. |
Working on #317, I found it to be a total pain to deal with dynamically populating the right sidebar (templates can be a list or a comma-separated string, I didn't explore why it was like this), the user may have defined some specific template per page, etc. So I ended up opting for an easier solution. It seems to me that users on mobile are also less likely to open the right side bar. |
The current location is somewhat intrusive. I don't want it to be a higher priority than the TOC, but moving it below the TOC somewhat removes the functionality this PR tries to achieve. |
I agree, but it is a bit of an advertisement, and I don't like we prioritize that over the documentation itself, which is why I originally suggested the right sidebar. Could we add it next to the logo dots you suggested next to the logo? That would make it stand out from the rest of the topbar. |
Updated to display the dropdown below the TOC. Feedback from the HoloViz meeting on this feature was:
I'm sure there's a better way to display this (somehow in the navbar), and I would have preferred it to be above the TOC as it's a global UI element, but I don't want to spend too much time on this, and the outcome is decent for a first iteration. |
I hesitated making this an extension but felt it'd be easier to adopt (no PR to open basically) if it was just inherited from the shared conf.py file. nbsite users can still opt-out the feature by setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not the prettiest button, but LGTM.
Curious - how does this work on mobile?
Suggestion to make holoviz.org and all the holoviz sites more exposed (exposed at all in fact besides the sometimes common domain name) on all the sites that are built with nbsite (technically, those that inherit from the shared conf file). Putting the dropdown in the primary sidebar as the navbar can get quite crowded (Panel for example).
examples.holoviz.org:
nbsite:
hvplot:
EDIT:
nbsite_hv_sidebar_dropdown = {}
inconf.py
nbsite_hv_sidebar_dropdown['dropdown_value'] = {'text': 'HoloViz websites'}
, useful for instance for holoviz.org.