[DO NOT MERGE] Test 298 #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converts markdown text to iterable of tuples, where first item is the full link like [a](b.ipynb) and second item is the name of the notebook, for example b.ipynb
Function to get potential link targets for a notebook
+ fix bug
A method which creates a link to the source file based on notebook markdown link and target filename
* Return the file paths instead of just file 'stems'
* Check first all matches with full path, then check matches without the digit part
* Take relative path of target instead of just the filename
logic was opposite
+ also made the method private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick check to see if the doc builds correctly for #298.