Node-to-node send/receive #746

lucksus · 2018-12-11T23:39:39Z

Usage

Define receive callback in define_zome! next to genesis:

define_zome! {
...
    genesis: || { Ok(()) }

    receive: |payload| {
        format!("Received: {}", payload)
    }

    functions: {

Use hdk::send to asynchronously send and receive the return value of the receive callback from the other node:

fn handle_send_message(to_agent: Address, message: String) -> String {
    match hdk::send(to_agent, message) {
        Ok(response) => response,
        Err(error) => error.to_string(),
    }
}

Yes, you can have a receive callback in each zome. hdk::send calls only map to the receive callback of the zome in which send gets called.

Chunks

receive added to define_zome! macro
CustomDirectMessage added
hc_send/invoke_send implemented
custom_send action creator and Future that waits for the result to appear in the (network) state
handle_custom_direct_message workflow that runs on the receiving end, calls the callback and dispatches an action to send the response

zippy · 2018-12-12T04:05:07Z

super woot, but tests didn't pass :-(

codecov · 2018-12-12T13:11:10Z

Codecov Report

Merging #746 into develop will decrease coverage by 1.12%.
The diff coverage is 22.34%.

@@             Coverage Diff             @@
##           develop     #746      +/-   ##
===========================================
- Coverage    73.31%   72.19%   -1.11%     
===========================================
  Files          138      142       +4     
  Lines         4690     4789      +99     
===========================================
+ Hits          3438     3457      +19     
- Misses        1252     1332      +80

Impacted Files	Coverage Δ
core/src/action.rs	`100% <ø> (ø)`	⬆️
hdk-rust/src/api.rs	`0% <ø> (ø)`	⬆️
core/src/nucleus/ribosome/callback/mod.rs	`67.17% <0%> (ø)`	⬆️
...rc/network/reducers/handle_custom_send_response.rs	`0% <0%> (ø)`
core/src/network/reducers/mod.rs	`95.13% <0%> (-2.43%)`	⬇️
core/src/network/reducers/send_direct_message.rs	`78.95% <0%> (-9.28%)`	⬇️
core/src/network/actions/custom_send.rs	`0% <0%> (ø)`
core/src/nucleus/ribosome/api/send.rs	`0% <0%> (ø)`
core/src/workflows/handle_custom_direct_message.rs	`0% <0%> (ø)`
core/src/network/state.rs	`100% <100%> (ø)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a32f4...77444f3. Read the comment docs.

codecov · 2018-12-12T13:11:10Z

Codecov Report

Merging #746 into develop will decrease coverage by 1.05%.
The diff coverage is 28.58%.

@@             Coverage Diff             @@
##           develop     #746      +/-   ##
===========================================
- Coverage    73.76%   72.72%   -1.04%     
===========================================
  Files          141      145       +4     
  Lines         4733     4842     +109     
===========================================
+ Hits          3491     3521      +30     
- Misses        1242     1321      +79

Impacted Files	Coverage Δ
core/src/action.rs	`100% <ø> (ø)`	⬆️
hdk-rust/src/api.rs	`0% <ø> (ø)`	⬆️
core/src/workflows/handle_custom_direct_message.rs	`0% <0%> (ø)`
...rc/network/reducers/handle_custom_send_response.rs	`0% <0%> (ø)`
hdk-rust/src/error.rs	`0% <0%> (ø)`	⬆️
core/src/network/actions/custom_send.rs	`0% <0%> (ø)`
core/src/nucleus/ribosome/callback/mod.rs	`67.17% <0%> (ø)`	⬆️
core/src/nucleus/ribosome/api/send.rs	`0% <0%> (ø)`
core/src/network/reducers/send_direct_message.rs	`96% <100%> (+7.77%)`	⬆️
core/src/network/state.rs	`100% <100%> (ø)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c669e7...5a05493. Read the comment docs.

zippy

I approve this because changes needed are minor (comment updates mostly)

However, there's one thing missing here which we had in proto which is timeout. Currently this blocks for ever, and we need to allow setting timeout as a followup.

core/src/network/actions/custom_send.rs

core/src/network/direct_message.rs

core/src/nucleus/ribosome/api/send.rs

core/src/workflows/handle_custom_direct_message.rs

hdk-rust/tests/integration_test.rs

…-rust into send-receive

Co-Authored-By: lucksus <[email protected]>

…-rust into send-receive

lucksus · 2018-12-12T16:42:38Z

Implemented all your points, @zippy. Yes, the timeout, was thinking about this and planning to add it as follow up. Or should I add it here and now?

zippy · 2018-12-12T17:00:56Z

I'm ok with followup unless you think it's really easy.

One other thing I forgot was that there's no app_spec example. That should also be a followup.

Connoropolous · 2018-12-12T17:38:29Z

hdk-rust/wasm-test/src/lib.rs

@@ -333,6 +333,13 @@ fn hdk_test_entry() -> Entry {
    Entry::App(hdk_test_app_entry_type(), hdk_test_entry_value())
 }

+fn handle_send_message(to_agent: Address, message: String) -> String {


So send and receive can pass/return String, can it use other types?

Like could receive return a ZomeApiResult?

I tried with a Result<String, String> but discovered a bug in JsonString::from<Result<>>. Already synced with @thedavidmeister. So I reverted back to just String for now.

Basically possible but tried to keep the scope small for this one.

I see, ok well knowing that we will implement a complex struct, not just a string eases my mind on this one 👍

oh yeah i forgot about that bug

i'd better actually fix that! 😅

Is there a follow up created for this one @lucksus @thedavidmeister ?

Connoropolous · 2018-12-12T17:41:22Z

core/src/network/direct_message.rs

+/// This is direct message that got created by the zome code through hdk::send().
+#[derive(Serialize, Deserialize, Clone, PartialEq, Debug, DefaultJson)]
+pub struct CustomDirectMessage {
+    /// We have to track which zome sent the message so we can call the


That's an interesting point... so an app can have one receive callback per zome?

But it could handle different event types, if they were passed as data, and using a match in receive?

@Connoropolous pretty similar to how websockets works i guess, you can send and receive strings, but dispatching logic and simulating request/response behaviour is BYO

Connoropolous · 2018-12-12T17:43:37Z

core/src/nucleus/ribosome/callback/receive.rs

+
+    let zome_call = ZomeFnCall::new(
+        zome,
+        "no capability since this is a callback",


I thought we weren't calling this capability anymore? Trait?

We haven't removed "capability" from the code yet. Otherwise this function wouldn't expect a capability name as second parameter.

Connoropolous · 2018-12-12T17:45:57Z

hdk-rust/src/api.rs

+/// [define_zome!](macro.defineZome.html) macro.
+///
+/// This functions blocks and returns the result returned by the `receive` callback on
+/// the other side.


I want to add example code in here to this description, but I am open to / happy to do that as a followup

lucksus · 2018-12-12T17:53:36Z

@zippy, timeout added: 5b50169

core/src/network/actions/custom_send.rs

Co-Authored-By: lucksus <[email protected]>

Connoropolous · 2018-12-13T17:55:36Z

Wooot!

lucksus added 14 commits December 11, 2018 19:34

"receive" added to define_zome! macro

b53bf2b

Adjust hdk::send signature

15f07e7

Integration test for send/receive in hdk

258a699

hdk::send() with SendArgs

8caf8b8

CustomDirectMessage

af4645e

Network::actions::custom_send

9631a0d

hc_send -> invoke_send() -> network::actions::custom_send

4fdbdaa

ribosome::callback::receive and CallbackResult::Receive(String)

9075ce8

handle_custom_direct_message workflow and usage in network handler

e07dd1a

Handling of custom send result

3a00a57

Fix invoke_send to return a result

75eaf8b

Fix serialization/wrapping of payload

a23a846

println--

70a464f

println--

af515cc

lucksus added the review label Dec 11, 2018

lucksus requested review from sphinxc0re, thedavidmeister, Connoropolous and zippy December 11, 2018 23:40

lucksus added 2 commits December 12, 2018 00:42

rustfmt

f9bc8d2

Adjust agent_id fixture

20c46f1

lucksus added 2 commits December 12, 2018 13:21

Fix some tests

8c29cb6

Add dummy hc_send in integration tests to make windows build work

77444f3

Merge branch 'develop' into send-receive

42c31eb

zippy approved these changes Dec 12, 2018

View reviewed changes

lucksus added 2 commits December 12, 2018 17:33

Add dummy hc_send to example rustdocs so they can compile in windows CI

5ab7729

Merge branch 'send-receive' of https://github.com/holochain/holochain…

abe76af

…-rust into send-receive

zippy and others added 6 commits December 12, 2018 17:35

typo in comment

e679c81

Co-Authored-By: lucksus <[email protected]>

test instance name = test name

1758785

Merge branch 'send-receive' of https://github.com/holochain/holochain…

181dc77

…-rust into send-receive

println--

6eb2e62

custom_send code comments

677ddd1

invoke_send code comments

10696eb

Connoropolous reviewed Dec 12, 2018

View reviewed changes

SendDirectMessageTimeout and test

5b50169

Connoropolous reviewed Dec 12, 2018

View reviewed changes

core/src/network/actions/custom_send.rs Outdated Show resolved Hide resolved

typo in comment

334dfcf

Co-Authored-By: lucksus <[email protected]>

Connoropolous approved these changes Dec 12, 2018

View reviewed changes

lucksus and others added 2 commits December 12, 2018 19:36

rustfmt

3836dcb

Merge branch 'develop' into send-receive

950ee14

thedavidmeister approved these changes Dec 13, 2018

View reviewed changes

lucksus and others added 4 commits December 13, 2018 15:11

rustfmt

434d223

Merge branch 'develop' into send-receive

9ea2c12

Merge branch 'develop' into send-receive

941b9ff

Merge branch 'develop' into send-receive

5a05493

lucksus merged commit dda6f96 into develop Dec 13, 2018

lucksus removed the review label Dec 13, 2018

lucksus deleted the send-receive branch December 14, 2018 13:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node-to-node send/receive #746

Node-to-node send/receive #746

lucksus commented Dec 11, 2018

zippy commented Dec 12, 2018 •

edited

Loading

codecov bot commented Dec 12, 2018

codecov bot commented Dec 12, 2018 •

edited

Loading

zippy left a comment

lucksus commented Dec 12, 2018

zippy commented Dec 12, 2018

Connoropolous Dec 12, 2018

lucksus Dec 12, 2018

Connoropolous Dec 12, 2018

thedavidmeister Dec 13, 2018

Connoropolous Dec 13, 2018

Connoropolous Dec 12, 2018

thedavidmeister Dec 13, 2018

Connoropolous Dec 12, 2018

lucksus Dec 12, 2018

Connoropolous Dec 12, 2018

Connoropolous Dec 12, 2018

lucksus Dec 12, 2018

lucksus commented Dec 12, 2018

Connoropolous commented Dec 13, 2018

Node-to-node send/receive #746

Node-to-node send/receive #746

Conversation

lucksus commented Dec 11, 2018

Usage

Chunks

zippy commented Dec 12, 2018 • edited Loading

codecov bot commented Dec 12, 2018

Codecov Report

codecov bot commented Dec 12, 2018 • edited Loading

Codecov Report

zippy left a comment

Choose a reason for hiding this comment

lucksus commented Dec 12, 2018

zippy commented Dec 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucksus commented Dec 12, 2018

Connoropolous commented Dec 13, 2018

zippy commented Dec 12, 2018 •

edited

Loading

codecov bot commented Dec 12, 2018 •

edited

Loading