Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Debug Conductor API #1661

Merged
merged 13 commits into from
Aug 20, 2019
Merged

Debug Conductor API #1661

merged 13 commits into from
Aug 20, 2019

Conversation

lucksus
Copy link
Collaborator

@lucksus lucksus commented Aug 14, 2019

PR summary

This adds conductor API functions for the purpose of debugging and showing detailed debug information in a windowed UI like Holoscape.

Added functions:

  • debug/running_instances
  • debug/state_dump
  • debug/fetch_cas

followups

Using these functions in a debug view in Holoscape.

changelog

Please check one of the following, relating to the CHANGELOG-UNRELEASED.md

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

@lucksus lucksus marked this pull request as ready for review August 16, 2019 18:37
pub trait ConductorDebug {
fn running_instances(&self) -> Result<Vec<String>, HolochainError>;
fn state_dump_for_instance(&self, instance_id: &String) -> Result<StateDump, HolochainError>;
fn get_type_and_content_from_cas(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use HcResult instead of Result here and several other places, but not terribly important.

Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just a small comment mistake to fix.

conductor_api/src/interface.rs Outdated Show resolved Hide resolved
@zippy zippy merged commit 32d9458 into develop Aug 20, 2019
@zippy zippy deleted the debug-conductor-api branch October 4, 2019 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants