Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

remove nodejs conductor #1510

Merged
merged 4 commits into from
Jun 13, 2019
Merged

remove nodejs conductor #1510

merged 4 commits into from
Jun 13, 2019

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented Jun 12, 2019

PR summary

node conductor moving back to holochain/holochain-nodejs#17

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

reinstate over at other repo

changelog

Please check one of the following, relating to the CHANGELOG-UNRELEASED.md

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

@thedavidmeister thedavidmeister changed the title WIP: remove nodejs remove nodejs conductor Jun 12, 2019
Copy link
Collaborator

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff!

I just want to note, before this PR can be merged, we should address that the JS scaffold code is not adjusted for use with playbook yet, and I'm thinking, isn't this likely to break that?

@maackle
Copy link
Collaborator

maackle commented Jun 13, 2019

@Connoropolous I guess as long as the npm package is published, the scaffold will also be fine, because the scaffold is just importing from npm anyway. When we change the scaffold to use diorama, that will mark the official switch/deprecation, but people are still free to use whichever test runner they want.

Copy link
Collaborator

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given #1512 has been created and @maackle has committed to it, I'm good.

@zippy zippy merged commit 12b8bc6 into develop Jun 13, 2019
@zippy zippy deleted the 2019-06-12-node-b-gone branch October 4, 2019 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants