This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Bridge error log #1448
Merged
Bridge error log #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucksus
commented
May 29, 2019
conductor_api/src/conductor/base.rs
Outdated
| assert_eq!( | ||
| result.unwrap(), | ||
| JsonString::from("{\"Err\":{\"Internal\":\"{\\\"kind\\\":{\\\"ErrorGeneric\\\":\\\"{\\\\\\\"code\\\\\\\":-32602,\\\\\\\"message\\\\\\\":\\\\\\\"Holochain Instance Error: Zome function \'non-existent-function\' not found in Zome \'greeter\'\\\\\\\"}\\\"},\\\"file\\\":\\\"core/src/nucleus/ribosome/runtime.rs\\\",\\\"line\\\":\\\"225\\\"}\"}}" | ||
| ) |
There was a problem hiding this comment.
So this test does not test the log output but I tested the log output by running this test with --nocapture and watching the output.
We are not doing log testing (yet?) and I did not add log tests (as in testing for the existence of specific log outputs) because it feels like overkill.
zippy
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Adds log outputs for errors happening in
hdk::call, including bridge errors.changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)