Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

2019 04 21 binary derivations #1306

Merged
merged 13 commits into from
Apr 28, 2019
Merged

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented Apr 21, 2019

PR summary

downloads "current" binaries into nix-shell

something like the hcup idea but for nixos

sits on top of #1292 (land that first)

part of the release process will be to bump the version and hashes once artifacts are deployed, this will need to be iterated a few times to make it smooth

at some point (soon) we will want to make it easy for consumers to pin binaries as well as roll forward with each weekly cycle

supports mac and linux (although i don't have a debian/ubuntu to test on)

questions

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

holochain and hc should be available in nix-shell

# should error
holochain -V
# should error
hc -V
# drop into nix-shell
nix-shell
# should report holochain 0.0.12-alpha1
holochain -V
# should report hc 0.0.12-alpha1
hc -V

nixos

[thedavidmeister@nixos:~/holochain-rust]$ holochain
holochain: command not found

[thedavidmeister@nixos:~/holochain-rust]$ hc
hc: command not found

[thedavidmeister@nixos:~/holochain-rust]$ nix-shell

[nix-shell:~/holochain-rust]$ holochain -V
holochain 0.0.12-alpha1

[nix-shell:~/holochain-rust]$ hc -V
hc 0.0.12-alpha1

[nix-shell:~/holochain-rust]$ 

mac

davidmeister@Davids-MacBook-Pro:~/holochain-rust$ holochain
-bash: holochain: command not found
davidmeister@Davids-MacBook-Pro:~/holochain-rust$ hc
-bash: hc: command not found
davidmeister@Davids-MacBook-Pro:~/holochain-rust$ nix-shell

[nix-shell:~/holochain-rust]$ holochain -V
holochain 0.0.12-alpha1

[nix-shell:~/holochain-rust]$ hc -V
hc 0.0.12-alpha1

[nix-shell:~/holochain-rust]$ 

alpine docker

bash-4.4# holochain -V
bash: holochain: command not found
bash-4.4# hc -V
bash: hc: command not found
bash-4.4# nix-shell

[nix-shell:/holochain-rust/build]# holochain -V
holochain 0.0.12-alpha1

[nix-shell:/holochain-rust/build]# hc -V
hc 0.0.12-alpha1

[nix-shell:/holochain-rust/build]# 

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

  • what is a good workflow for getting linux and mac hashes at release time?
  • what is the best way to expose pinning for consumers?

changelog

Please check one of the following, relating to the CHANGELOG

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so there is an 'Unreleased' CHANGELOG item, with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

@thedavidmeister thedavidmeister changed the title WIP: 2019 04 21 binary derivations 2019 04 21 binary derivations Apr 22, 2019
@lucksus lucksus changed the base branch from develop to 2019-04-18-split-nix April 24, 2019 12:55
@thedavidmeister thedavidmeister changed the base branch from 2019-04-18-split-nix to develop April 28, 2019 09:08
@thedavidmeister thedavidmeister merged commit 7af6f18 into develop Apr 28, 2019
@zippy zippy deleted the 2019-04-21-binary-derivations branch October 4, 2019 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants