-
Notifications
You must be signed in to change notification settings - Fork 267
Conversation
Switching to autodump policy dumps to the db everytime there is a change. test bench_file_eav_many_to_one ... bench: 276,004,040 ns/iter (+/- 127,700,185) when running periodic policy it was a 92% increase, running this gives a 75% increase. Lose some performance but it is still good. |
I was looking into this already merged PR because I just encountered a new performance issue. In this latest FlameGraph that I just created after fixing the 100% CPU issue, I guess your benchmark does not include running a node, and I also guess that in the context of a running instance the performance hit looks different..? I would like to have this be revisited. I don't think we need nor should dump on every change. |
This reverts commit 80d529d.
Please check one of the following, relating to the CHANGELOG, which should be updated if relevant
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)