Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Autodump pickledb #1231

Merged
merged 7 commits into from
Apr 9, 2019
Merged

Autodump pickledb #1231

merged 7 commits into from
Apr 9, 2019

Conversation

StaticallyTypedAnxiety
Copy link
Contributor

Please check one of the following, relating to the CHANGELOG, which should be updated if relevant

  • my changes to the code affect some exposed aspect of the developer experience, and I have added an item to relevant 'Added, Fixed, Changed, Removed, Deprecated, or Security' heading under the 'Unreleased' heading of the CHANGELOG, with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • [x ] my changes to the code do not affect any exposed aspect of the developer experience

@StaticallyTypedAnxiety
Copy link
Contributor Author

StaticallyTypedAnxiety commented Apr 8, 2019

Switching to autodump policy dumps to the db everytime there is a change.

test bench_file_eav_many_to_one ... bench: 276,004,040 ns/iter (+/- 127,700,185)
test bench_file_eav_one_to_many ... bench: 286,338,120 ns/iter (+/- 142,272,851)
test bench_memory_eav_many_to_one ... bench: 1,607,075 ns/iter (+/- 2,202,613)
test bench_memory_eav_one_to_many ... bench: 1,355,982 ns/iter (+/- 406,924)
test bench_pickle_eav_many_to_one ... bench: 66,729,510 ns/iter (+/- 31,334,739)
test bench_pickle_eav_one_to_many ... bench: 64,792,690 ns/iter (+/- 31,317,922)

when running periodic policy it was a 92% increase, running this gives a 75% increase. Lose some performance but it is still good.

@zippy zippy merged commit 80d529d into develop Apr 9, 2019
@lucksus
Copy link
Collaborator

lucksus commented Apr 9, 2019

I was looking into this already merged PR because I just encountered a new performance issue. In this latest FlameGraph that I just created after fixing the 100% CPU issue, PicklDB::dump is the biggest bar:
Screenshot 2019-04-09 at 18 15 38

I guess your benchmark does not include running a node, and I also guess that in the context of a running instance the performance hit looks different..?

I would like to have this be revisited. I don't think we need nor should dump on every change.

lucksus pushed a commit that referenced this pull request Apr 10, 2019
struktured pushed a commit that referenced this pull request Apr 10, 2019
@zippy zippy deleted the autodump-pickledb branch October 4, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants