This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 267
Update mdbook to reflect "call" method changes #1203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maackle
added
help wanted
Extra attention is needed
good first issue
Good for newcomers
documentation
labels
Apr 2, 2019
@maackle I also really disliked the |
I'm ok with doing this update, but if we are going to do it, lets convert this PR/branch into not just a documentation change, but do the work here too. Also we should do it soon. Someone wanna take this on and add into the tree? |
I can definitely take it on next week, and maybe this week. We can bundle up #1191 with this work as well. |
But, @zippy if by "soon" you mean this week, maybe someone else can take it on |
Hey @dymayday how about you take these on!? |
Sure! I will be more than happy to do it as soon as I'm done with the guidebook, I don't want to mess with my first PR... |
2 tasks
Connoropolous
approved these changes
May 1, 2019
Connoropolous
changed the title
WIP: update mdbook to reflect "call" method changes
Update mdbook to reflect "call" method changes
May 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially complete update to mdbook to reflect changes to
call
RPC method. Still needs to be updated in two subsections.I also propose:
Also, params is a misnomer here anyway. According to generally accepted notions, "parameters" are the placeholders you put in a function definition, and "arguments" are the actual values you pass when invoking a function, and the latter is what we're doing here.
This is what I'm talking about
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)