Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

More helpful error message on missing public token #1125

Merged
merged 7 commits into from
Apr 9, 2019

Conversation

maackle
Copy link
Collaborator

@maackle maackle commented Mar 18, 2019

No description provided.

@maackle maackle requested a review from zippy March 18, 2019 18:11
@zippy
Copy link
Member

zippy commented Mar 20, 2019

Interesting. This last addition breaks a few tests. Apparently we have tests on DNAs with no zomes!

@zippy
Copy link
Member

zippy commented Apr 4, 2019

Looks like there's still an "Attempting to initialize DNA with zero zomes!"

@zippy zippy merged commit 430061a into develop Apr 9, 2019
@@ -0,0 +1,369 @@
use self::HolochainError::*;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh, did this file renamed and then re-added?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it again in #1240

maackle added a commit that referenced this pull request Apr 9, 2019
@maackle maackle mentioned this pull request Apr 9, 2019
1 task
struktured pushed a commit that referenced this pull request Apr 10, 2019
@zippy zippy deleted the public-token-error-message branch October 4, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants