DataNodeRef with single lifetime #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to fix the way DataTree::merge worked so that the tree did not inherit the lifetime of the context reference from the source tree the changes are being merged from. The removal of the second lifetime generic from DataNodeRef was done by Renato Westphal <[email protected]>, thanks! Signed-off-by: Christian Hopps <[email protected]>
choppsv1
force-pushed
the
datanoderef-lifetime
branch
from
a6cc0c5
to
72e8e94
Compare
rwestphal
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix way DataTree::merge worked so that the tree did not inherit the lifetime of the context reference from the source tree the changes are being merged from.
The removal of the second lifetime generic from DataNodeRef was done by Renato Westphal [email protected], thanks!