Exclude directories from the Composer archive #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in a lighter package when it is installed in `vendor` in consuming projects. This makes a difference on AWS Lambda where the package size is limited, and a smaller package implies better performances for cold starts. See https://madewithlove.com/gitattributes/ for more information.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
Coverage 97.96% 97.96%
Complexity 253 253
=========================================
Files 18 18
Lines 639 639
=========================================
Hits 626 626
Misses 13 13 Continue to review full report at Codecov.
|
hollodotme
requested changes
May 19, 2020
There was a problem hiding this comment.
Thanks @mnapoli, this is handy. I didn't know that it also affects the composer releases.
Only one thing though: Can you remove the bin/ directory from .gitattributes, because bin/fcgiget gets linked on composer install, so this would be a BC break, see: https://github.com/hollodotme/fast-cgi-client/blob/v3.1.1/composer.json#L20
|
As discussed with @mnapoli via DM:
|
Merged
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This results in a lighter package when it is installed in
vendorin consuming projects. This makes a difference on AWS Lambda where the package size is limited, and a smaller package implies better performances for cold starts.See https://madewithlove.com/gitattributes/ for more information.