Minor cleanup and isdimmable fix #821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is_dimmable test has been added for objects. is_dimmable can be implemented by a device class and return true for dimmable objects. This is modelled on a test that was in http_server.pl. I avoided changing Generic_Item to implement a default for this, although I really wanted to. This change makes the dimmable attribute an object property, not a class property -- this is important for a submission I will be making soon to add mqtt discovery. Cleaned up the code in Alexa and AOG that was trying to determine if an object was dimmable.
There are also a couple minor fixes to messages and comments.
My previous pull request #813 is also stacked in here.