Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue emulation module for Misterhouse #667

Merged
merged 28 commits into from
Feb 20, 2017
Merged

Conversation

waynieack
Copy link
Contributor

This module has been tested with Google Home and the Amazon Echo. It should work for anything that supports the Hue bridge.

Wayne Gatlin added 22 commits December 15, 2016 22:26
…e' when calling a configured sub so a real state can be returned by the sub
… to read_table_A.pl so users can define them the the mht file.
@hplato
Copy link
Collaborator

hplato commented Feb 10, 2017

OK, Lieven, the CI stuff is great! It looks like there is a missing dependancy:

IO::Socket::Multicast

This brings up the whole site_libs vs loading separately, but I'm voting for keeping things encapsulated to make the install and setup as simple as possible. The Alexa stuff is a great compliment to homebridge, so IMHO it should work at startup. Wayne can you add in that dependancy and resubmit?

@waynieack
Copy link
Contributor Author

I tried adding the module, but the test still fails. I am not sure whats going wrong with it.

@hplato
Copy link
Collaborator

hplato commented Feb 11, 2017 via email

@waynieack
Copy link
Contributor Author

waynieack commented Feb 12, 2017 via email

@hplato
Copy link
Collaborator

hplato commented Feb 20, 2017

Hey Wayne,

Great!

One more dependancy to add. CI dies on missing Net::Ethernet;

Can't locate Net/Address/Ethernet.pm in @inc

Can you add that dependancy and update the pull request?

@hplato
Copy link
Collaborator

hplato commented Feb 20, 2017

OK, one more (interesting, this one didn't show up when I installed IO::Socket::Multicast)

Can't locate Net/Ifconfig/Wrapper.pm in @inc

@hplato hplato merged commit ca05237 into hollie:master Feb 20, 2017
@hplato
Copy link
Collaborator

hplato commented Feb 20, 2017

Looks good, no errors at startup!

@waynieack
Copy link
Contributor Author

Net::Address::Ethernet is only used for discovering the local IP and can be manually defined in the mh.private.ini so I just did a eval on it and log the error below if its not defined. This way the user can install the module if they want to.

[Alexa] Error: Net::Address::Ethernet is not installed... Please install it or define the local IP and mac in alexaHttpIp/alexaMac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants