Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #612

Closed
wants to merge 117 commits into from
Closed

Add #612

wants to merge 117 commits into from

Conversation

jsiddall
Copy link
Contributor

No description provided.

hplato and others added 30 commits May 31, 2015 11:41
… connection to devices randomly

(or at least the single fan device I have)
…ateTime so the pinging

could be intelligent. Hopfully a poll cycle ping will keep devices always alive
Made it simpler to add devices for child objects. Will add -0-38 to device ID if not present
Refinements to make communication tracker more accurate
Simplified devices, child devices just need the device ID. -0-38 will be appended if not present
Refinements to make communication tracker more accurate
…olortouch

Conflicts:
	lib/Venstar_Colortouch.pm
Razberry - Zwave Lock child object added
Add FastOn & FastOff for RemoteLinc
Replace print statements with &::print_log to provide consistent
logging.
Socket_Item print _log clean up
each light bulb has a diffrent brightness behaviour, so more smaller
steps are needed.
hplato and others added 27 commits May 25, 2016 14:10
Always run at least once if duration greater than min runtime
…up logging and moved debug logs to data_dir.
Added Doorbird Doorbell module
EvapoTranspiration Calculations
Merged proposed change in #559 by @jduda after perltidy change.
Added support for html and device to API call
This pull request adds the required files to run a basic regression test on the MisterHouse code using Travis.

All control is in the `.travis.yml` file in the root of the repository.

Every time somebody commits code, a new build is triggered on Travis.

The test code that is executed is:
```
mh -code_dir code/test
```

With the current code that is present in that folder, MisterHouse is started, runs for one minute and then exits.

Results are here: https://travis-ci.org/hollie/misterhouse/builds

Rationale:
 * to offer a framework that allows automatic code verification for new pull requests
 * to speed up acceptance of new pull requests that pass the tests

Note:
 * I had to change the exit code of MisterHouse to '0' for an intended exit (so that the test can stop at a certain point in time). That exit code used to be 1, and I changed both the exit code and the loop code that checks the exit code. We need to check if there are other uses of the exit code '1' that could be broken by this change
 * More test code needs to be added to the `code/test/` folder. E.g. performing a basic check if the web interface is up, adding specific test code for modules, ...

So: this is a start, I hope we can expand it to cover larger parts of the MisterHouse code.
Add new MIME types for Apache reverse proxy
removed $version reference from ia7_collection_upgrader
removed a sort from json_server.pl to slightly optimize
Added all stable releases and 5.08 on request of Howard.
Add Travis CI regression test support
Ia7 fixes $version and hash issue
@jsiddall jsiddall closed this Aug 13, 2016
@hollie
Copy link
Owner

hollie commented Aug 13, 2016

Hey @jsiddall,

since you've closed both pull requests that you created you've probably seen that your created the pull request against the stable branch instead of against master.

First of all: thanks for contributing code to MisterHouse.

If you want a detailed description on how to contribute, please refer to this page: https://github.com/hollie/misterhouse/wiki/Contributing#creating-a-pull-request-for-new-contributors

If you have further questions, do not hesitate to ask us!

Kind regards,
Lieven.

@jsiddall
Copy link
Contributor Author

On 2016-08-13 16:38, Lieven Hollevoet wrote:

Hey @jsiddall [1],

since you've closed both pull requests that you created you've
probably seen that your created the pull request against the stable
branch instead of against master.

First of all: thanks for contributing code to MisterHouse.

If you want a detailed description on how to contribute, please refer
to this page:
https://github.com/hollie/misterhouse/wiki/Contributing#creating-a-pull-request-for-new-contributors
[2]

If you have further questions, do not hesitate to ask us!

Kind regards,
Lieven.

Yeah, I was trying to commit one file using only github but failed
miserably. Sorry for the noise.

Anyway, I think I eventually did it right using your procedure as pull
request 613. Let me know if there is anything else I need to do.

Thanks,

Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants