Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #577

Merged
merged 2 commits into from
Mar 20, 2016
Merged

Master #577

merged 2 commits into from
Mar 20, 2016

Conversation

jonwhitear
Copy link
Contributor

This is my first pull request, so please let me know if i got it wrong!

Replace print statements with &::print_log to provide consistent
logging.
Socket_Item print _log clean up
@hollie
Copy link
Owner

hollie commented Mar 6, 2016

Looks OK for merge to me, thanks for the pull request.

I'll leave some time for others to comment. If no other input is received then I'll merge this next week.

Lieven.

@jonwhitear
Copy link
Contributor Author

Lieven,

Thanks. Sorry for the delay in getting back to you - I’ve been out of town for a while.

Cheers,

Jon

On 7 Mar 2016, at 6:52 AM, Lieven Hollevoet [email protected] wrote:

Looks OK for merge to me, thanks for the pull request.

I'll leave some time for others to comment. If no other input is received then I'll merge this next week.

Lieven.


Reply to this email directly or view it on GitHub #577 (comment).

hollie added a commit that referenced this pull request Mar 20, 2016
print_log cleanup in Socket_Item.
@hollie hollie merged commit cd5fdf5 into hollie:master Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants