Added a white space in the sensor matching to prevent TempSpare10 from m...

[hplato]

Added in a whitespace check, sensor was matching both TempSpare10 and TempSpare1.

[hollie]

Hello @hplato,

thanks for the bug fix. I wonder: you state in your comment you added a whitespace in the matching, but as far as I see you added a \W to the regular expression. This is a match on a non-word character.

Would it be not safer to change the regular expression to

$sensor_names !~ /$rrd_ref$/i

This way the regular expression only matches on the complete value of $rrd_ref.

Note: I did not test this out, I have no codebase where I can verify this on.

Kind regards,
Lieven.

[hplato]

I had a issue with sensor both matching TempSpare1 and TempSpare10. I believe this regex matches against a long string of rrd sensor names, so hence the match against a word. It works for me.

I fixed this a while back when working with Dan on the rrd shading issue, so i've forgotten most of the details around this.

Thanks for the QA!

Sent from my mobile device.

On Feb 18, 2015, at 1:15 AM, Lieven Hollevoet [email protected] wrote:

Hello @hplato,

thanks for the bug fix. I wonder: you state in your comment you added a whitespace in the matching, but as far as I see you added a \W to the regular expression. This is a match on a non-word character.

Would it be not safer to change the regular expression to

$sensor_names !~ /$rrd_ref$/i
This way the regular expression only matches on the complete value of $rrd_ref.

Note: I did not test this out, I have no codebase where I can verify this on.

Kind regards,
Lieven.

—
Reply to this email directly or view it on GitHub.

[hollie]

Hey @hplato,

thanks for the feedback. Merged!

Regards,
Lieven.