Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/bin/tagline.pl throws an error if a user defined data dir is used #27

Closed
krkeegan opened this issue Dec 20, 2012 · 3 comments
Closed

Comments

@krkeegan
Copy link
Collaborator

The recommended setup for MH is to have a user defined data_dir. However, tagline.pl looks for file data/remarks/1100tags.txt in the user defined directory, but never looks in the Pgm_Root/Data directory.

A stupid bug, likely in a little used feature, but it should be fixed since users may see a visible error in the output.

krkeegan referenced this issue in krkeegan/misterhouse Dec 20, 2012
Add a conditional check for the file 1100tags.txt.  If it doesn't exist in the user
defined data directory, then default to the Pgm_root/data directory.
@hollie
Copy link
Owner

hollie commented Dec 20, 2012

Idem, could you please create a pull request for this commit too?

Eases the integration in the main code.

Thanks,
Lieven.

@krkeegan
Copy link
Collaborator Author

Yes, I will create requests later today. I am trying to patch up bugs as I
find them.

On Thu, Dec 20, 2012 at 11:18 AM, Lieven Hollevoet <[email protected]

wrote:

Idem, could you please create a pull request for this commit too?

Eases the integration in the main code.


Reply to this email directly or view it on GitHubhttps://github.com//issues/27#issuecomment-11586799.

@hollie
Copy link
Owner

hollie commented Dec 20, 2012

Cool Kevin,

thanks!

Lieven.

Op 20-dec.-2012, om 20:19 heeft krkeegan [email protected] het volgende geschreven:

Yes, I will create requests later today. I am trying to patch up bugs as I
find them.

On Thu, Dec 20, 2012 at 11:18 AM, Lieven Hollevoet <[email protected]

wrote:

Idem, could you please create a pull request for this commit too?

Eases the integration in the main code.


Reply to this email directly or view it on GitHubhttps://github.com//issues/27#issuecomment-11586799.


Reply to this email directly or view it on GitHub.

hollie pushed a commit that referenced this issue Dec 22, 2012
Add a conditional check for the file 1100tags.txt.  If it doesn't exist in the user
defined data directory, then default to the Pgm_root/data directory.
@hollie hollie closed this as completed Dec 22, 2012
hplato pushed a commit that referenced this issue Feb 2, 2022
@hplato hplato mentioned this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants