Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insteon: Issues that can be Solved by Checking State_Final #185

Closed
krkeegan opened this issue May 15, 2013 · 0 comments
Closed

Insteon: Issues that can be Solved by Checking State_Final #185

krkeegan opened this issue May 15, 2013 · 0 comments
Labels
bug

Comments

@krkeegan
Copy link
Collaborator

@peloy discovered a very unique bug. At multiple points in the code, MH checks to see if the state being set is equal to the device's current state, if so, the set command is ignored. However, in the unique case in which multiple set commands are issued in the same pass, the current code doesn't work as expected. This is because the state of a device is not actually updated until the start of the next pass.

I have found the issue in at least the following locations:

  • The AllLink Cleanup/Direct Logic in BaseInsteon at Line 725
  • The MotionSensor _Process_Message logic. (I am already re-writing this class, so I will attack this issue there)
krkeegan added a commit to krkeegan/misterhouse that referenced this issue May 17, 2013
@krkeegan
Insteon_MotionSensor: Defer Identical Set Messages Received in the Sa…
e6be80f 
…me Pass

Fixes the issue found by @peloy in which multiple set messages could be called in one pass.  By checking state_final, this ensures that the subsequent messages are deferred as expected.

Partially fixes hollie#185
krkeegan added a commit to krkeegan/misterhouse that referenced this issue May 17, 2013
@krkeegan
Insteon: Catch Cleanup Messages Sent in the Same Pass as AllLink Mess…
780ada2 
…ages

Issue discovered by @peloy.  MH should be ignoring the cleanup message received after an AllLink message.  However, both messages were previously processed if they were received in the same pass.  This resolves that discrepancy by checking what the state of the object will be at the start of the next pass.

Partially fixes hollie#185
@krkeegan krkeegan mentioned this issue May 21, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krkeegan