Docs - Add document for connector #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add connector and core pages - Add plugin npm2yarn - Config to show more level on TOC
huyleminh01
added
PR: Docs 📝
|
|
||
| ## Prerequisites | ||
|
|
||
| Before you begin, ensure you have met the following requirements: |
There was a problem hiding this comment.
I think:
We already have Prerequisites header. So I think you could shorten this one to:
Please ensure you have met the following requirements:
...|
|
||
| Before you begin, ensure you have met the following requirements: | ||
|
|
||
| - **Node.js**: You need to have Node.js version 18.0.0 or higher installed. |
There was a problem hiding this comment.
There is only one requirement her. I suggest:
## Prerequisites
- Require Nodejs version 18.0.0 or higher.
There was a problem hiding this comment.
Fixed in commit 790438d
nguyenalter
reviewed
Aug 19, 2024
huyleminh01
force-pushed
the
docs/add-connector-module
branch
from
79d857e to
e2f83b9
Compare
nguyenalter
approved these changes
Aug 19, 2024
huyphung1602
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor js module document:
Issue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done