Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move data type of axes limits and mouse plot pos from float to double #2400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamuMazzi
Copy link
Contributor

Description:
Lately this topic has been discussed more than usual (like here) so I decided to make public what I've done some time ago. It's a simple and probably naive solution, so I'm open to improvements.

This solution actually closes #1847 (I've tested the example) and hopefully it should close #2067, #386 but on the other side I think it's still not enough precision for this #2157

Concerning areas:
I've also read that @v-ein has (rightly) made the point of performance, but it shouldn't really be a problem (as far as I read, both from @axeldavy and the internet) also because double type has been already used in a while by ImPlot.

Notes:
I've also changed the data structures from ImVec2 to ImPlotRange, I hope it's not a problem.

Also move some internal data structures from `ImVec2` to `ImPlotRange`
@khazaddim
Copy link

khazaddim commented Nov 4, 2024

I would really love to see this implemented. I want to be able to get the position of my mouse in time on a candlestick chart with minute resolution (or with this change second as well I think!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precision Error When Calculating Minute Candle Series Insufficient precision of the get_plot_mouse_pos()
2 participants