fix: text widget state update #1933 #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both of the provided minimal examples were verified as working. |
|
Update item state was corrected to include the label part of the text widget |
hoffstadt
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Item state update was left inside of the drawing of the widget, this was most likely done due to left label causing two spots were state was updated. when refactoring the code this was missed. This was tested by inspecting the item state of the demo text color and word wrapping section and viewing the item registry to ensure states were updated correctly when the item was interacted with by the mouse and the item width was changed with the word wrapping slider.
The old item state update was removed and the new item state update function was used.