Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax fix in writer #87

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Syntax fix in writer #87

merged 1 commit into from
Oct 25, 2021

Conversation

rcoup
Copy link
Contributor

@rcoup rcoup commented Oct 25, 2021

Fixes obvious syntax error, bug was introduced in be5a392

$ cc --version
Apple clang version 13.0.0 (clang-1300.0.29.3)
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

$ make
...
In file included from /Users/rcoup/code/untwine/epf/Cell.cpp:15:
/Users/rcoup/code/untwine/epf/Writer.hpp:51:1: error: expected unqualified-id
/  the queue even if they aren't full so that they can be reused. The active buffer for a
^
/Users/rcoup/code/untwine/epf/Writer.hpp:51:31: error: missing terminating ' character [-Werror,-Winvalid-pp-token]
/  the queue even if they aren't full so that they can be reused. The active buffer for a
                              ^
/Users/rcoup/code/untwine/epf/Cell.cpp:24:21: error: member access into incomplete type 'untwine::epf::Writer'
    m_buf = m_writer->fetchBuffer();
                    ^
/Users/rcoup/code/untwine/epf/Cell.hpp:31:7: note: forward declaration of 'untwine::epf::Writer'
class Writer;
      ^
/Users/rcoup/code/untwine/epf/Cell.cpp:31:25: error: member access into incomplete type 'untwine::epf::Writer'
        m_buf = m_writer->fetchBufferBlocking();
                        ^
/Users/rcoup/code/untwine/epf/Cell.hpp:31:7: note: forward declaration of 'untwine::epf::Writer'
class Writer;
      ^
/Users/rcoup/code/untwine/epf/Cell.cpp:43:17: error: member access into incomplete type 'untwine::epf::Writer'
        m_writer->enqueue(m_key, std::move(m_buf), size);
                ^
/Users/rcoup/code/untwine/epf/Cell.hpp:31:7: note: forward declaration of 'untwine::epf::Writer'
class Writer;
      ^
/Users/rcoup/code/untwine/epf/Cell.cpp:45:17: error: member access into incomplete type 'untwine::epf::Writer'
        m_writer->replace(std::move(m_buf));
                ^
/Users/rcoup/code/untwine/epf/Cell.hpp:31:7: note: forward declaration of 'untwine::epf::Writer'
class Writer;
      ^
6 errors generated.
...

Fixes FTBFS from be5a392
@abellgithub abellgithub merged commit efd6644 into hobuinc:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants