Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement point format 6, 7, and 8 (only) support #72

Merged
merged 21 commits into from
Oct 6, 2021
Merged

Conversation

hobu
Copy link
Collaborator

@hobu hobu commented Sep 17, 2021

@abellgithub not quite sure if this is what we want, but it is a start.

@hobu
Copy link
Collaborator Author

hobu commented Sep 22, 2021

This is ready for review. It is a combo of things:

  • Allow the user to set --format to 6, 7, or 8 for single_file
  • Complete extra bytes support
  • Add the stats VLR and update the info VLR with pointers to it

@hobu hobu requested a review from abellgithub September 22, 2021 19:41
@hobu
Copy link
Collaborator Author

hobu commented Sep 28, 2021

If you're not and a user is selecting, say, PDRF 6, but has Red, it should be written as an EB field.

I disagree with this idea for behavior. First, if we promote Red to EB fields, it will compress much worse than if the user uses the correct PDRF. There must be a way to strip off the color fields. Otherwise, why bother having COPC support 6, 7, and 8. Maybe just have COPC only support 8 (I don't hate this idea. If there's no values in the color fields, they compress to nothing).

Maybe it would be useful for the user to provide a list of fields they want dropped or a list of fields they want kept as part of a conversion (using PDAL dimension ID names).

@hobu
Copy link
Collaborator Author

hobu commented Sep 29, 2021

This is ready to merge, but there will need to be updates after the next lazperf release to have this code use the (replicated) VLR definitions in hobuinc/laz-perf#102 Those of course are dependent upon COPC specification being complete.

bu/Processor.cpp Show resolved Hide resolved
untwine/Common.hpp Outdated Show resolved Hide resolved
untwine/FileDimInfo.hpp Outdated Show resolved Hide resolved
untwine/Untwine.cpp Outdated Show resolved Hide resolved
bu/CopcSupport.hpp Show resolved Hide resolved
@abellgithub
Copy link
Collaborator

I can merge this, but I'd like to remove the COPC VLR stuff. That means that CI will fail because you're pulling lazperf from Conda, but I kinda don't care since Untwine isn't really something that's distributed. I have a few small changes that I'd like to make but I can do them after merge.

Let me know.

@hobu
Copy link
Collaborator Author

hobu commented Oct 6, 2021

I can merge this, but I'd like to remove the COPC VLR stuff.

Yeah, that's fine. Update the private members to use the laz-perf definitions and we can roll out the new release of laz-perf.

@abellgithub abellgithub merged commit d23cca5 into main Oct 6, 2021
@abellgithub abellgithub deleted the pointformat branch October 7, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants