Flush Cell cache when we run out. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| std::unique_lock<std::mutex> lock(m_mutex); | ||
| if (nonblock && m_buffers.empty() && m_count >= MaxBuffers) |
There was a problem hiding this comment.
Should this buffers.empty() check be locked?
There was a problem hiding this comment.
Probably. Thx.
There was a problem hiding this comment.
Actually, no. Or to put it another way, it already is.
The lock that was in the BufferCache has been removed. The lock that's used is now the one that's in the Writer, that owns the buffer cache. Writer::fetchBuffer() acquires the lock before calling BufferCache::fetch(). It passes the lock along so that it can be UN-locked if we need to wait on a CV.
hobu
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.