Skip to content
This repository has been archived by the owner on Aug 27, 2020. It is now read-only.

Merge packages of different integration #8

Merged
merged 21 commits into from
Apr 14, 2020
Merged

Merge packages of different integration #8

merged 21 commits into from
Apr 14, 2020

Conversation

hoangvvo
Copy link
Owner

@hoangvvo hoangvvo commented Apr 14, 2020

I am approaching this differently. Instead of providing different integration packages, we opt-in for one general package. Inspired by apollographql/apollo-server#3184

@github-actions
Copy link

Benchmarks from current PR

Hey, @hoangvvo. I ran some benchmarks on this PR.

graphyne-server-express

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 0.0 3662.2 +3662.2
Latency 0.00 26.44 ⚠️ +26.44
Throughput/Mb 0.00 22.85 +22.85

graphyne-server

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 3927.6 3937.8 +10.2
Latency 24.71 24.62 -0.09
Throughput/Mb 24.41 24.47 +0.06

Thanks for the contribution 👍

@github-actions
Copy link

Benchmarks from current PR

Hey, @hoangvvo. I ran some benchmarks on this PR.

graphyne-server-express

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 0.0 4129.4 +4129.4
Latency 0.00 23.75 ⚠️ +23.75
Throughput/Mb 0.00 25.76 +25.76

graphyne-server

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 4306.5 4289.2 ⚠️ -17.3
Latency 22.84 22.89 ⚠️ +0.05
Throughput/Mb 26.77 26.66 ⚠️ -0.11

Thanks for the contribution 👍

@github-actions
Copy link

Benchmarks from current PR

Hey, @hoangvvo. I ran some benchmarks on this PR.

graphyne-server-express

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 0.0 3390.5 +3390.5
Latency 0.00 28.88 ⚠️ +28.88
Throughput/Mb 0.00 21.15 +21.15

graphyne-server

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 3682.2 3720.2 +38.0
Latency 26.60 26.36 -0.24
Throughput/Mb 22.89 23.12 +0.23

Thanks for the contribution 👍

@github-actions
Copy link

Benchmarks from current PR

Hey, @hoangvvo. I ran some benchmarks on this PR.

graphyne-server-express

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 0.0 3964.3 +3964.3
Latency 0.00 24.75 ⚠️ +24.75
Throughput/Mb 0.00 24.72 +24.72

graphyne-server

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 4230.5 4198.2 ⚠️ -32.3
Latency 23.19 23.42 ⚠️ +0.23
Throughput/Mb 26.29 26.09 ⚠️ -0.20

Thanks for the contribution 👍

@github-actions
Copy link

Benchmarks from current PR

Hey, @hoangvvo. I ran some benchmarks on this PR.

graphyne-server-express

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 0.0 4278.1 +4278.1
Latency 0.00 22.94 ⚠️ +22.94
Throughput/Mb 0.00 26.68 +26.68

graphyne-server

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 4412.1 4393.1 ⚠️ -19.0
Latency 22.24 22.33 ⚠️ +0.09
Throughput/Mb 27.42 27.31 ⚠️ -0.11

Thanks for the contribution 👍

@github-actions
Copy link

Benchmarks from current PR

Hey, @hoangvvo. I ran some benchmarks on this PR.

graphyne-server-express

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 0.0 3773.7 +3773.7
Latency 0.00 25.96 ⚠️ +25.96
Throughput/Mb 0.00 23.54 +23.54

graphyne-server

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 3942.1 3933.8 ⚠️ -8.3
Latency 24.89 24.98 ⚠️ +0.09
Throughput/Mb 24.50 24.45 ⚠️ -0.05

Thanks for the contribution 👍

@github-actions
Copy link

Benchmarks from current PR

Hey, @hoangvvo. I ran some benchmarks on this PR.

graphyne-server

hoangvvo/graphyne master hoangvvo/graphyne merge-packages Change
Requests/s 3538.5 3824.9 +286.4
Latency 27.70 25.65 -2.05
Throughput/Mb 21.99 23.77 +1.78

Thanks for the contribution 👍

@hoangvvo hoangvvo merged commit fee7c0c into master Apr 14, 2020
@hoangvvo hoangvvo deleted the merge-packages branch April 14, 2020 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant