Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pdfcrop completely silent if --verbose is not given #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ras52
Copy link

@ras52 ras52 commented May 16, 2021

See #7.

@davidcarlisle
Copy link
Member

actually I was thinking of suggesting in #7 that you/we simply guard the printing with the existing verbose option (so it wouldn't print by default) rather than adding a new option

@ras52
Copy link
Author

ras52 commented May 16, 2021

actually I was thinking of suggesting in #7 that you/we simply guard the printing with the existing verbose option (so it wouldn't print by default) rather than adding a new option

I had assumed the author wanted the copyright notice printing by default. But if that's not the case, I would be very happy having this controlled by the existing --verbose option.

@davidcarlisle
Copy link
Member

davidcarlisle commented May 16, 2021

I guess Heiko did, but I think having debug and verbose and quiet options is too confusing, so personally if we do this at all I'd bundle this with the existing verbose option which already controls printing of the ghostscript copyright.

@ras52
Copy link
Author

ras52 commented May 16, 2021

Fair enough. I've updated the pull request to do that.

@ras52 ras52 changed the title Add --quiet option Make pdfcrop completely silent if --verbose is not given May 16, 2021
@davidcarlisle
Copy link
Member

Thanks for the PR/

Personally I'd be happy droping the message by default, but some push back on that, and perhaps I should check with the original author. I'll leave it here for a bit see if there is any consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants