Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump zarr with support for dimension_separator #105

Merged
merged 2 commits into from
Jul 13, 2021
Merged

bump zarr with support for dimension_separator #105

merged 2 commits into from
Jul 13, 2021

Conversation

manzt
Copy link
Member

@manzt manzt commented Jul 12, 2021

@will-moore @joshmoore

Zarr.js now has support for dimension_separator, so the store should no long need to modify chunk keys. It would be my preference that we rely on zarr rather than inspecting the ome metadata to determine how to initialize a custom store.

It is my impression that datasets coming from the IDR (or generated with bioformats2raw) will include dimension_separator in the array metadata.

@joshmoore
Copy link

Speaking for the Python & Java implementations, the ome-zarr v0.2+ implementations should explicitly pass / which should trigger the zarr implementations to set dimension_separator in the metadata, so that sounds like a fair assumption.

@will-moore
Copy link
Collaborator

This is working great for me, with the sample data from #103 and other data I've created locally.
I'm adding more to #104 just now, so once this is merged I can fix conflicts etc. Thanks.

@manzt
Copy link
Member Author

manzt commented Jul 13, 2021

Ok great, merging!

@manzt manzt merged commit 596c928 into main Jul 13, 2021
@manzt manzt deleted the bump-zarr branch July 13, 2021 14:29
@manzt manzt mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants