Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025 deal with intermittent upload error #779

Merged
merged 8 commits into from
Jul 28, 2022

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Jul 22, 2022

Description

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-2025

Link to staging deployment URL (or set N/A)

https://ui-martinfosco-ui7791.scp-staging.biomage.net/

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/data-management 248.74 KB (🟡 +97 B) 771.11 KB
/experiments/[experimentId]/data-processing 499.05 KB (🟡 +37 B) 1021.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #779 (ee91deb) into master (63a4d07) will increase coverage by 0.00%.
The diff coverage is 88.88%.

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   83.86%   83.87%           
=======================================
  Files         473      473           
  Lines        8069     8074    +5     
  Branches     1568     1570    +2     
=======================================
+ Hits         6767     6772    +5     
  Misses       1244     1244           
  Partials       58       58           
Impacted Files Coverage Δ
src/redux/actions/samples/createSampleFile.js 83.33% <50.00%> (ø)
src/utils/upload/processUpload.js 82.35% <100.00%> (+1.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cosa65 cosa65 changed the title [DRAFT] 2025 fix intermittent upload error 2025 fix intermittent upload error Jul 25, 2022
@cosa65 cosa65 marked this pull request as ready for review July 25, 2022 14:28
@cosa65 cosa65 changed the title 2025 fix intermittent upload error 2025 deal with intermittent upload error Jul 25, 2022
@cosa65
Copy link
Member Author

cosa65 commented Jul 25, 2022

From what I have seen, the origin of the error seems to be related to a chrome caching issue in the 2 calls (OPTIONS and PUT) involved with doing the axios PUT request to s3.
This triggers a CORS error because chrome changes the headers being sent between these 2 calls.

@cosa65 cosa65 force-pushed the 2025-fix-intermittent-upload-error branch from b35cf1b to f0b0313 Compare July 25, 2022 18:09
@cosa65 cosa65 merged commit bf04a37 into master Jul 28, 2022
@cosa65 cosa65 deleted the 2025-fix-intermittent-upload-error branch July 28, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants