[BIOMAGE-1774] - Check sample file sizes #773
Conversation
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
| Page | Size (compressed) |
|---|---|
global |
522.38 KB (🟡 +462 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/data-management |
248.56 KB (🟡 +1.79 KB) |
770.94 KB |
/experiments/[experimentId]/data-processing |
497.14 KB (-1 B) |
1019.51 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
+ Coverage 83.74% 83.83% +0.09%
==========================================
Files 471 472 +1
Lines 7934 8000 +66
Branches 1531 1551 +20
==========================================
+ Hits 6644 6707 +63
+ Misses 1238 1235 -3
- Partials 52 58 +6
|
|
with the (valid) WT1 sample I am getting that the features file is invalid. I also tried with some bigger experiments and I nothing seems to happen (I don't get any invalid error but the samples don't show up either) |
kafkasl
force-pushed
the
check-file-sizes
branch
from
afb774a to
36dd920
Compare
| const [ | ||
| expectedNumFeatures, | ||
| expectedNumBarcodes, | ||
| ] = await extractSampleSizes(matrix); | ||
|
|
||
| const numBarcodesFound = await getNumLines(barcodes); | ||
| const numFeaturesFound = await getNumLines(features); |
There was a problem hiding this comment.
There are error messages for invalid matrix file size, but I don't see it getting checked here. Are we checking the matrix file size? @kafkasl
Description
Add a check for sample files. Check if samples have the correct barcodes, features and matrix files.
To test, you'll need to modify the some of your samples to trigger the errors:
If you need help in testing, ask Agi.
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1774
Link to staging deployment URL (or set N/A)
https://ui-agi-lumpy-flounder.scp-staging.biomage.net/
Links to any PRs or resources related to this PR
N/A
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional