Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-603] - Add capability to select granular cell sets in heatmap #771

Merged
merged 15 commits into from
Jul 15, 2022

Conversation

aerlaut
Copy link
Contributor

@aerlaut aerlaut commented Jul 13, 2022

Description

Add ability to select metadata from the select data option in the custom heatmap

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-603

https://ui-agi-muggy-numbat.scp-staging.biomage.net/

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

N/A

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 516.82 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/experiments/[experimentId]/data-exploration 533.59 KB (🟢 -1.69 KB) 1.03 MB
/experiments/[experimentId]/data-processing 498.95 KB (🟢 -357 B) 1015.77 KB
/experiments/[experimentId]/plots-and-tables/dot-plot 476.25 KB (🟢 -475 B) 993.08 KB
/experiments/[experimentId]/plots-and-tables/embedding-categorical 472.89 KB (🟢 -362 B) 989.72 KB
/experiments/[experimentId]/plots-and-tables/embedding-continuous 473.4 KB (🟢 -559 B) 990.23 KB
/experiments/[experimentId]/plots-and-tables/frequency 475.18 KB (-4 B) 992 KB
/experiments/[experimentId]/plots-and-tables/heatmap 546.38 KB (🟢 -1.64 KB) 1.04 MB
/experiments/[experimentId]/plots-and-tables/marker-heatmap 571.28 KB (🟢 -1.72 KB) 1.06 MB
/experiments/[experimentId]/plots-and-tables/violin 473.69 KB (🟢 -495 B) 990.52 KB
/experiments/[experimentId]/plots-and-tables/volcano 477.16 KB (🟢 -358 B) 993.99 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #771 (e50fea1) into master (6a6f371) will increase coverage by 0.26%.
The diff coverage is 95.34%.

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   83.42%   83.69%   +0.26%     
==========================================
  Files         462      462              
  Lines        7861     7867       +6     
  Branches     1537     1538       +1     
==========================================
+ Hits         6558     6584      +26     
+ Misses       1249     1229      -20     
  Partials       54       54              
Impacted Files Coverage Δ
src/components/plots/styling/SelectData.jsx 79.48% <ø> (ø)
...components/plots/styling/violin/ViolinControls.jsx 60.00% <ø> (ø)
...[experimentId]/plots-and-tables/dot-plot/index.jsx 93.61% <ø> (ø)
src/redux/reducers/componentConfig/initialState.js 100.00% <ø> (ø)
...eatmap/vega/utils/generateVegaHeatmapTracksData.js 62.06% <66.66%> (ø)
...omponents/data-exploration/heatmap/HeatmapPlot.jsx 90.00% <100.00%> (+0.22%) ⬆️
...nents/plots/helpers/heatmap/populateHeatmapData.js 98.64% <100.00%> (+5.89%) ⬆️
...nts/plots/helpers/heatmap/vega/generateVegaData.js 100.00% <100.00%> (ø)
...s/helpers/heatmap/vitessce/generateVitessceData.js 100.00% <100.00%> (ø)
.../[experimentId]/plots-and-tables/heatmap/index.jsx 91.17% <100.00%> (+18.95%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6f371...e50fea1. Read the comment docs.

@aerlaut aerlaut enabled auto-merge July 15, 2022 08:41
@aerlaut aerlaut merged commit 648ae1f into master Jul 15, 2022
@aerlaut aerlaut deleted the add-granular-select-data branch July 15, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants