[BIOMAGE-1989]- Reduce UI build time #770
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,18 +54,15 @@ jobs: | |
| env: | ||
| CI: true | ||
| steps: | ||
| - id: checkout | ||
| name: Check out source code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - id: setup-node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '14' | ||
| cache: 'npm' | ||
|
|
||
| - id: install | ||
| name: Install dependencies | ||
|
|
@@ -133,7 +130,7 @@ jobs: | |
| steps: | ||
| - id: checkout | ||
| name: Check out source code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - id: download-build-out | ||
| name: Download Next.js build output | ||
|
|
@@ -205,6 +202,10 @@ jobs: | |
| env: | ||
| REPO_NAME: ${{ steps.ref.outputs.repo-name }} | ||
|
|
||
| - id: setup-buildx | ||
| name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v2 | ||
|
|
||
| - id: build | ||
| name: Build Docker image | ||
| uses: docker/build-push-action@v2 | ||
|
|
@@ -214,7 +215,10 @@ jobs: | |
| platforms: linux/amd64 | ||
| tags: ${{ format('{0}/{1}:{2}', steps.login-ecr.outputs.registry, steps.ref.outputs.repo-name, steps.ref.outputs.image-tag) }} | ||
| push: false | ||
| load: true | ||
| build-args: READONLY_API_TOKEN_GITHUB=${{ secrets.READONLY_API_TOKEN_GITHUB }} | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max | ||
|
Comment on lines
+220
to
+221
There was a problem hiding this comment. how did you work out that we need to have these parameters? There was a problem hiding this comment. I learned that the docker/build-push-action has internal caching capabilities and we're not using it. It has an option for github actions, and I'm following the examples here: https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md#github-cache |
||
|
|
||
| - id: push | ||
| name: Push docker image to ECR | ||
|
|
@@ -246,7 +250,7 @@ jobs: | |
| steps: | ||
| - id: checkout | ||
| name: Check out source code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - id: setup-aws | ||
| name: Configure AWS credentials | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw from the error in this run: https://github.com/hms-dbmi-cellenics/ui/runs/7291171952?check_suite_focus=true and read about it from the
docker/build-push-actionsection about driver: https://github.com/docker/build-push-action#usage