Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-2001] Replace gene selection #759

Merged
merged 26 commits into from
Jul 22, 2022
Merged

Conversation

jszpila314
Copy link
Contributor

@jszpila314 jszpila314 commented Jul 5, 2022

Description

Replace selection box in gene selection in Plots and Tables with search box and gene re-ordering tree. Limit the height of the tree and scroll the tree automatically when element is hovered near the bottom or the top.
These changes affect the Marker Heatmap and the Dot Plot.

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-2001

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 522.37 KB (-11 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/experiments/[experimentId]/plots-and-tables/dot-plot 496.96 KB (🟡 +22.52 KB) 1019.33 KB
/experiments/[experimentId]/plots-and-tables/marker-heatmap 569.63 KB (🟡 +168 B) 1.07 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@jszpila314 jszpila314 changed the title [BIOMAGE-2001] replace gene selection, add autoscroll replace gene selection, add autoscroll Jul 5, 2022
@jszpila314 jszpila314 changed the title replace gene selection, add autoscroll Replace gene selection Jul 5, 2022
@jszpila314 jszpila314 changed the title Replace gene selection [BIOMAGE-2001] Replace gene selection Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #759 (42a5ac9) into master (34cbf65) will increase coverage by 0.01%.
The diff coverage is 82.82%.

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   83.83%   83.85%   +0.01%     
==========================================
  Files         472      473       +1     
  Lines        8000     8064      +64     
  Branches     1551     1564      +13     
==========================================
+ Hits         6707     6762      +55     
- Misses       1235     1244       +9     
  Partials       58       58              
Impacted Files Coverage Δ
.../hierarchical-tree-genes/HierarchicalTreeGenes.jsx 100.00% <ø> (ø)
...c/components/plots/styling/MarkerGeneSelection.jsx 100.00% <ø> (ø)
src/components/plots/ScrollOnDrag.jsx 47.36% <47.36%> (ø)
[...imentId]/plots-and-tables/marker-heatmap/index.jsx](https://codecov.io/gh/hms-dbmi-cellenics/ui/pull/759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hms-dbmi-cellenics#diff-c3JjL3BhZ2VzL2V4cGVyaW1lbnRzL1tleHBlcmltZW50SWRdL3Bsb3RzLWFuZC10YWJsZXMvbWFya2VyLWhlYXRtYXAvaW5kZXguanN4) 90.27% <66.66%> (+0.13%) ⬆️
...[experimentId]/plots-and-tables/dot-plot/index.jsx 94.44% <92.42%> (+0.82%) ⬆️
src/components/plots/GeneReorderTool.jsx 100.00% <100.00%> (+2.56%) ⬆️
src/components/plots/GeneSearchBar.jsx 100.00% <100.00%> (+4.16%) ⬆️
...rc/redux/actions/componentConfig/updatePlotData.js 100.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@jszpila314 jszpila314 marked this pull request as ready for review July 15, 2022 07:43
@jszpila314 jszpila314 merged commit c45177e into master Jul 22, 2022
@jszpila314 jszpila314 deleted the replace-gene-selection branch July 22, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants