Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips about future support #754

Merged
merged 5 commits into from
Jul 5, 2022
Merged

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Jul 1, 2022

Description

Implemented from this thread https://this-is-biomage.slack.com/archives/C01A1DRDXUJ/p1656522333658759.

I wrote the text based on the tooltips that we show for Configure Embedding's upcoming clustering methods, but trying to keep it less wordy

Details

URL to issue

N/A

https://ui-martinfosco-ui754.scp-staging.biomage.net/

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@cosa65 cosa65 marked this pull request as ready for review July 1, 2022 16:43
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #754 (9975c44) into master (1ec9e3c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files         463      463           
  Lines        7844     7847    +3     
  Branches     1534     1537    +3     
=======================================
+ Hits         6542     6545    +3     
  Misses       1249     1249           
  Partials       53       53           
Impacted Files Coverage Δ
...rocessing/DataIntegration/NormalisationOptions.jsx 53.33% <ø> (ø)
...a-processing/DataIntegration/CalculationConfig.jsx 80.43% <100.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec9e3c...9975c44. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/experiments/[experimentId]/data-processing 499.3 KB (🟡 +40 B) 1016.03 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@cosa65 cosa65 merged commit 4071e04 into master Jul 5, 2022
@cosa65 cosa65 deleted the add-tooltips-about-future-support branch July 5, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants