1902 remove project from redux #752
Conversation
…ment slice instead
…teProject -> deleteExperiment and delete folder for project action creators
cosa65
changed the title
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Twelve Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
cosa65
changed the title
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 83.50% 83.40% -0.11%
==========================================
Files 478 463 -15
Lines 7956 7844 -112
Branches 1549 1534 -15
==========================================
- Hits 6644 6542 -102
+ Misses 1258 1249 -9
+ Partials 54 53 -1
Continue to review full report at Codecov.
|
src/__test__/components/data-management/NewProjectModal.test.jsx
Outdated
Show resolved
Hide resolved
src/__test__/components/data-management/ShareExperimentModal.test.jsx
Outdated
Show resolved
Hide resolved
| @@ -39,7 +39,7 @@ const MetadataPopover = (props) => { | |||
| onCancel(); | |||
| }} | |||
| deleteEnabled={false} | |||
| value={`Track ${existingMetadata.filter((key) => key.match('Track-')).length + 1}`} | |||
| value={`Track ${existingMetadata.filter((key) => key.match('Track_')).length + 1}`} | |||
There was a problem hiding this comment.
Unrelated bug that is in prod right now, default create metadata track names are not scaling correctly
Description
This is a pretty big PR, so talk to me to have a call and go over it together
But as a brief explanation of the general rule I followed:
I focused on replacing the project-related redux slice/action creators/actions/reducers with experiment counterparts.
I didn't try to remove the word project from every place where it was, but rather focus on just removing the core part of project (redux). My reasoning for this is that the project redux slice is the part that involves changing a lot of different files without any way around that while cleaning it up from every place (for example, from the samples side of redux) is simpler and doesn't have as much coupling with a lot of different parts of the code.
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1902
Link to staging deployment URL (or set N/A)
https://ui-martinfosco-ui752.scp-staging.biomage.net/
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional