Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dimensionality reduction method except for Seurat v4 #737

Merged
merged 8 commits into from
Jun 16, 2022

Conversation

Kristian-A
Copy link
Contributor

@Kristian-A Kristian-A commented Jun 14, 2022

Description

Disable dimensionality reduction method options for all data integration methods except Seurat v4, found in the "Data Integration" step of the pipeline. Display N/A if the dimensionality reduction options are not applicable to (disabled for) the method. This is done by adding an additional parameter to each integration method enableDimReductionMethod: true if the dimensionality reduction method is relevant to the integration method (can be omitted if the dropdown should be disabled as undefined/null is evaluated to false).

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-1959

Link to staging deployment URL (or set N/A)

https://ui-kristian-ui737.scp-staging.biomage.net/

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #737 (4cf8891) into master (d9bce83) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   82.77%   82.78%           
=======================================
  Files         480      480           
  Lines        8228     8231    +3     
  Branches     1621     1622    +1     
=======================================
+ Hits         6811     6814    +3     
  Misses       1355     1355           
  Partials       62       62           
Impacted Files Coverage Δ
...a-processing/DataIntegration/CalculationConfig.jsx 79.06% <75.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bce83...4cf8891. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/experiments/[experimentId]/data-processing 499.88 KB (🟡 +14 B) 1021.64 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@StefanBabukov StefanBabukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kristian-A Kristian-A enabled auto-merge June 16, 2022 08:22
@Kristian-A Kristian-A disabled auto-merge June 16, 2022 08:45
@Kristian-A Kristian-A merged commit 47f7569 into master Jun 16, 2022
@Kristian-A Kristian-A deleted the remove-dimensionality-reduction branch June 16, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants