-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dimensionality reduction method except for Seurat v4 #737
Conversation
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
=======================================
Coverage 82.77% 82.78%
=======================================
Files 480 480
Lines 8228 8231 +3
Branches 1621 1622 +1
=======================================
+ Hits 6811 6814 +3
Misses 1355 1355
Partials 62 62
Continue to review full report at Codecov.
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
src/components/data-processing/DataIntegration/CalculationConfig.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Disable dimensionality reduction method options for all data integration methods except Seurat v4, found in the "Data Integration" step of the pipeline. Display N/A if the dimensionality reduction options are not applicable to (disabled for) the method. This is done by adding an additional parameter to each integration method
enableDimReductionMethod: true
if the dimensionality reduction method is relevant to the integration method (can be omitted if the dropdown should be disabled as undefined/null is evaluated to false).Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1959
Link to staging deployment URL (or set N/A)
https://ui-kristian-ui737.scp-staging.biomage.net/
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional