Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata track naming #732

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Fix metadata track naming #732

merged 4 commits into from
Jun 13, 2022

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Jun 13, 2022

Description

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-1928

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

Copy link
Contributor

@aerlaut aerlaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test for this

@cosa65 cosa65 enabled auto-merge June 13, 2022 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 522.5 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #732 (4a1c7a3) into master (57ad24a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #732   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files         481      481           
  Lines        8228     8228           
  Branches     1655     1655           
=======================================
  Hits         6883     6883           
  Misses       1284     1284           
  Partials       61       61           
Impacted Files Coverage Δ
src/redux/actions/projects/updateMetadataTrack.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef10b9a...4a1c7a3. Read the comment docs.

@cosa65 cosa65 merged commit 2f85121 into master Jun 13, 2022
@cosa65 cosa65 deleted the 1928-fix-metadata-track-rename branch June 13, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants