-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BIOMAGE-1836] Implement metadata tracks-specific endpoints #699
Conversation
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
Page | Size (compressed) |
---|---|
global |
522.04 KB (🟡 +280 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/data-management |
293 KB (🟡 +51 B) |
815.04 KB |
/experiments/[experimentId]/data-processing |
499.54 KB (-2 B) |
1021.58 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
The code looks good, just needs some unit tests |
03a8584
to
1af303b
Compare
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 83.07% 83.09% +0.01%
==========================================
Files 477 479 +2
Lines 8067 8096 +29
Branches 1592 1602 +10
==========================================
+ Hits 6702 6727 +25
- Misses 1303 1308 +5
+ Partials 62 61 -1
Continue to review full report at Codecov.
|
Description
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1836
Link to staging deployment URL (or set N/A)
N/A (in api)
Links to any PRs or resources related to this PR
hms-dbmi-cellenics/api#343
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional