Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VISIUM EXAMPLE] disable file check #570

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Nov 30, 2021

Background

Link to issue

Link to staging deployment URL

https://ui-visium-demo.scp-staging.biomage.net/

Links to any Pull Requests related to this

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format
  • Validated that current unit tests work as expected and are enough

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging
  • Passed integration tests

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #570 (23e16fd) into master (d8ac6be) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   71.39%   70.81%   -0.58%     
==========================================
  Files         151      151              
  Lines        4604     4602       -2     
  Branches      925      924       -1     
==========================================
- Hits         3287     3259      -28     
- Misses       1301     1327      +26     
  Partials       16       16              
Impacted Files Coverage Δ
...omponents/data-management/LaunchAnalysisButton.jsx 65.82% <0.00%> (-32.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ac6be...23e16fd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant