Fix bug in metadata tracks #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xverges
approved these changes
May 20, 2021
kafkasl
added a commit
that referenced
this pull request
Jun 15, 2021
* Implement metadata input (#239) * create new metadata column * update delete metadata * disable add metadata if no samples * insert metadata into sample * add and delete metadata * handle metadata name collision * disable launch analysis when no project and sample * Integration tests fixes (#232) * Prevent unit test from calling the real API * Male progressbar accesible/testable * useEffect was ignoring required updates * Remove console.log * File reuploads (#242) * Disable addition of single files * REMOVE BEFORE PR Fix local upload * Restore Storage.configure custom prefix override * Add UploadDetailsModal without functionality * Switch sample fileNames to using a set for easier replacement * Fix tests * Change updateSampleFile action/reducer to use diff instead for easier refactoring of compressAndUpload * Refactor, add single file upload and implement onRetry for error modal * Add onRetry functionality to error uploadDetails modal * Change onRetry and onReplace for single callback onUpload with both functionalities * Change error prop to status to allow for using same modal for success * Add basic information shown on upload success * Fix size to mbytes calculation * Add download functionality * Add last modified date to modal * Fix lastModified not updating correctly * Run mock credentials only on development enviornment * Remove no longer necessary aux function * Remove repeated code * Send genes.tsv and features.tsv only as features.tsv * Add file version to metadata * Fix tests * Add restrictions to file upload by file selector so that it only accepts folders and works correctly * Add hover select cursor and minor style fixes * Fix tests * Fix * Fix positioning * Fix positioning * Remove unnecessary beforeEach * Minor changes based on code review * Filter out hidden files * Visual fixes * Add rejection based on file name * Fix tests and minor gub * Fix * Text correction based on comments Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> * small eye-bleeding typo (#247) * Notify api data upload (#245) * create projects and samples data to database * update projects and samples data to database * delete projects and samples data from database * Enable FastMNN (#246) * Enable FastMNN * Add noIntegration * Change value to unisample and fastmnn * Add option classes * Grammar change * rephrase sentenced * Vicky's comment Co-authored-by: Martin Fosco <[email protected]> * Fix error status bug (#251) * Fix error status bug * Add same check to other type of file upload error Co-authored-by: Martin Fosco <[email protected]> * Add extra check in ifs for embeddingData to not be null or empty (#252) Co-authored-by: Martin Fosco <[email protected]> * fixed doublet tooltip (#248) Co-authored-by: Oliver Gibson <[email protected]> * disable data integration settings on unisample (#256) * disable data integration settings on unisample * remove check for enabled property on data integration * Gem2s loading UI (#257) * Launch new experiment (#254) * Create new modal to select experiment * Store experiment in DynamoDB * Redux for gem2s (#260) * Rename pipeline status updates redux setup to backend status updates to better reflect the fact it is showing state of worker, pipeline and gem2s * Change redux store pipelineStatus property to backendStatus to more accurately reflect what it is actually storing * Other minor renaming of loadPipelineStatus redux action and of prop taken by loading screen of gem2s * Merge status * Write state for each of backend services separately * Fix tests snapshots * Add tests Co-authored-by: Martin Fosco <[email protected]> * Add clonedeep to value taken from getState() (#262) Co-authored-by: Martin Fosco <[email protected]> * Remove unused file (#249) * Add end-to-end authentication and authorization (#250) * Fix authentication error in the UI for local development * Add authorization to the UI * fix linting errors * refactor amplify * remove beautiful jwt reference * fix * Log fetch errors * Extra logging * Auth fixes + logging (#263) * Logging * Do not prevent console statements * More logging * Remove circular reference created by logging * Hopefully force 401 * Redirect to data management instead of default experiment * Auth.configure only server-side * Fix tracking of amplifyConfigured * getInitialProps only if server side * Fix broken guard on getInitialProps * Remove debug logging * Remove debug logging * Less noisy logging Co-authored-by: Xavier Verges <[email protected]> * Add cognito user and admin details to rbac can write (#264) * Fix authentication error in the UI for local development * Add authorization to the UI * fix linting errors * refactor amplify * remove beautiful jwt reference * fix * Log fetch errors * Extra logging * Switch create experiment to point to new create experiment endpoint * Remove error on merge * Add post fetch test Co-authored-by: Marcell Pek <[email protected]> Co-authored-by: Marcell Pék <[email protected]> Co-authored-by: Xavier Verges <[email protected]> Co-authored-by: Martin Fosco <[email protected]> * Make checking for strings in vega canvases more robust (#253) * Load projects samples (#258) * Add new CI pipeline for merging things into develop (#225) * Add new CI pipeline for merging things into develop (#226) * changed small text to trigger rebuild (#228) * changed small text to trigger rebuild * removed duplicated ci-dev.yaml * redoing the ticket * fix * fixes * fixes * fix * fixes * fix tests * small fix Co-authored-by: Pol Alvarez <[email protected]> * Select the proper redirect url BIOMAGE-997 (#266) * Select the proper redirect url * Remove useless comments * fix checking of uploaded samples (#269) * fix checking of uploaded samples * change to check for null * fix description bug * Load experiments (#272) * load experiments * map experiment object * throw error if fetch causes error * [BIOMAGE-1000] bad url handling to get the organism list (#268) * Different treatment for api and non api urls * Keep linter happy * Rename file * Clarify metadata showing unfiltered cell numbers (#270) * Handle gem2s response (#274) * Handle status updates * Fix tests (they rely on steps prop) * Remove unused steps prop * Fix tests Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Xavier Verges <[email protected]> * Fix loading logic of "new project" dialog * Fix authentication for projects [BIOMAGE-1006] (#267) * prevent create project if failed * fix json no body error * Increased the timeout for one violin plot test * We are not using fetchMock properly! Co-authored-by: Xavier Verges <[email protected]> * Revert "Fix loading logic of "new project" dialog" (#276) This reverts commit 43a9acf. * move call to backend status (#275) * Update project metadata (#261) * Updates to metadata name reflected in projects * Saving metadata saves to database * Address comments pr 272 (#273) * address comments * create tests for load experiments * fix ids accumulation, add test * Delete project delete experiment [BIOMAGE-948] (#279) * create experimentsDeleted actionType * fix bug deleting experiment ids * add reducer test * Prevent re-run pipeline if succeeded [BIOMAGE-1007] (#278) * rename pipelineStatus to pipelineStatusValues * display project uuid (#280) * [BIOMAGE-1002] Remove delay from Project Name validation (#282) * Validate project name inside useEffect * Removed failed attempt of clearing * Removed comment * [BIOMAGE-1012] - Prevent repeating notifications (#281) * add default push notification clear message time * remove notification manager * change push notification dispatches to fn calls * remove notification redux * remove error time for messages * not reloading experiments for old experiments without project UUID (#283) * Fix transition between gem2s and data processing (#277) * Fix various bugs * Wrong prop types Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Xavier Verges <[email protected]> * [BIOMAGE-1024] - Fix long project name hiding project controls (#284) * remove from title to normal description item * align buttons to the top * fix long project names in main area * stick "create new project" on top of list * new project modal state set as closed to avoid fluttering in & out (#286) * [BIOMAGE-1023] - Relaunch experiment from GEM2S error screen (#287) * relaunch experiment from GEM2S error screen * update last analyzed (#291) * Show data processing after qc is running (#295) * Remove qc update when the message received is an error (#289) Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> * Fix delete project showing error that should not appear (#297) * Move select action to before other updates in redux * Fix tests * Add filter to avoid reselecting delected project if it is first in list Co-authored-by: Martin Fosco <[email protected]> * validate metadata track name (#299) * validate metadata track name * only allow space in metadata name * more valid validation * [BIOMAGE-885] - Filter cells out of plot (#292) * [BIOMAGE-1045] Issues with launching metadata (#298) * fix * fix-tests * Disable dash metadata track (#302) * change from dash to underscore * fix metadata validation * [BIOMAGE-1041] The UI still shows the old experiment when a user launches a new experiment (#301) * Add new CI pipeline for merging things into develop (#225) * Add new CI pipeline for merging things into develop (#226) * changed small text to trigger rebuild (#228) * changed small text to trigger rebuild * removed duplicated ci-dev.yaml * fixes * fix * rework * fix tests * fix Co-authored-by: Pol Alvarez <[email protected]> * [BIOMAGE-963] - Add species metadata input (#296) * [BIOMAGE-989] - Work request throw error if pipeline has not yet succeeded (#300) * change sendWork to use fetchCachedWork * pass backendstatus to fetchcachedgene * [BIOMAGE-1026] Improved error messages (#290) * Common fetch error + user messages + await on dispatch * Address PR comments * Remove new awaits on dispatches (#305) Co-authored-by: Martin Fosco <[email protected]> * new flow for releases (#306) * added deployment for release/hotfixes PRs to master (#308) * adding new flow actions to master as a hotfix (#310) (#311) Co-authored-by: Pol Alvarez <[email protected]> * using tokens to allow flow to trigger testing * [BIOMAGE-760] - Show login screen if user is unauthenticated (#304) * Update ci-develop.yaml * update doublet score info (#303) * update doublet score info * update text * more pithy * update text based on Vicky's comment * add for each sample * wrong use of rest parameters (#321) * Update ci-develop.yaml * Update ci-develop.yaml * Delete files in s3 for deleted samples (#318) * Remove samples unnecessary ids field * Fix error on trying to decode a non json * Update DELETE call * Fix tests * Fix * Add cancel set up without the actual call for amplify * Fix delete files refactoring * Null upload promise on completion * Add missing nulls for amplify promises * Fix tests * Add source for flushPromises * Clean up comments * Remove commented line Co-authored-by: Martin Fosco <[email protected]> * Add await back (#327) Co-authored-by: Martin Fosco <[email protected]> * receiving notification from API on work-response (#328) * wip receiving notification from API on work-response * Add small comments and comment out dispatch(saveCellSets(experimentId)); * removed unused import * removed async * clean up Co-authored-by: Martin Fosco <[email protected]> * [BIOMAGE-1044] Add a needsRunning flag to gem2s pipeline status (#319) * Use the needsRunning flag of gem2s status before launching it * Disable launch button after it is clicked * Refactoring and fix issue with taskparams hash * Fix tests and minor bugfixes of experiments reducer Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> * [BIOMAGE-1109] Fix metadata not saving (#329) * Remove no longer used sample ids and remove properties that aren't samples from the updates * Remove samples extra loading * Fix tsts * Fix * User profile change details (#293) * Add new CI pipeline for merging things into develop (#225) * Add new CI pipeline for merging things into develop (#226) * changed small text to trigger rebuild (#228) * changed small text to trigger rebuild * removed duplicated ci-dev.yaml * changes * changes * fix * fix * fixes * change regular expression * cancel button * changes * email disabled error improvement * update * start workflow * changes Co-authored-by: Pol Alvarez <[email protected]> * Send redux disaptch action in correct shape (#332) Co-authored-by: ogibson <[email protected]> Co-authored-by: Anugerah Erlaut <[email protected]> Co-authored-by: Xavier Vergés <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Juanlu <[email protected]> Co-authored-by: ogibson-biomage <[email protected]> Co-authored-by: Oliver Gibson <[email protected]> Co-authored-by: Marcell Pék <[email protected]> Co-authored-by: Marcell Pek <[email protected]> Co-authored-by: StefanBabukov <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Pickering <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: ogibson <[email protected]>
kafkasl
added a commit
that referenced
this pull request
Jun 15, 2021
* adding new flow actions to master as a hotfix (#310) * flows triggering flows (#313) * Release version 0.0.1 (#333) * Implement metadata input (#239) * create new metadata column * update delete metadata * disable add metadata if no samples * insert metadata into sample * add and delete metadata * handle metadata name collision * disable launch analysis when no project and sample * Integration tests fixes (#232) * Prevent unit test from calling the real API * Male progressbar accesible/testable * useEffect was ignoring required updates * Remove console.log * File reuploads (#242) * Disable addition of single files * REMOVE BEFORE PR Fix local upload * Restore Storage.configure custom prefix override * Add UploadDetailsModal without functionality * Switch sample fileNames to using a set for easier replacement * Fix tests * Change updateSampleFile action/reducer to use diff instead for easier refactoring of compressAndUpload * Refactor, add single file upload and implement onRetry for error modal * Add onRetry functionality to error uploadDetails modal * Change onRetry and onReplace for single callback onUpload with both functionalities * Change error prop to status to allow for using same modal for success * Add basic information shown on upload success * Fix size to mbytes calculation * Add download functionality * Add last modified date to modal * Fix lastModified not updating correctly * Run mock credentials only on development enviornment * Remove no longer necessary aux function * Remove repeated code * Send genes.tsv and features.tsv only as features.tsv * Add file version to metadata * Fix tests * Add restrictions to file upload by file selector so that it only accepts folders and works correctly * Add hover select cursor and minor style fixes * Fix tests * Fix * Fix positioning * Fix positioning * Remove unnecessary beforeEach * Minor changes based on code review * Filter out hidden files * Visual fixes * Add rejection based on file name * Fix tests and minor gub * Fix * Text correction based on comments Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> * small eye-bleeding typo (#247) * Notify api data upload (#245) * create projects and samples data to database * update projects and samples data to database * delete projects and samples data from database * Enable FastMNN (#246) * Enable FastMNN * Add noIntegration * Change value to unisample and fastmnn * Add option classes * Grammar change * rephrase sentenced * Vicky's comment Co-authored-by: Martin Fosco <[email protected]> * Fix error status bug (#251) * Fix error status bug * Add same check to other type of file upload error Co-authored-by: Martin Fosco <[email protected]> * Add extra check in ifs for embeddingData to not be null or empty (#252) Co-authored-by: Martin Fosco <[email protected]> * fixed doublet tooltip (#248) Co-authored-by: Oliver Gibson <[email protected]> * disable data integration settings on unisample (#256) * disable data integration settings on unisample * remove check for enabled property on data integration * Gem2s loading UI (#257) * Launch new experiment (#254) * Create new modal to select experiment * Store experiment in DynamoDB * Redux for gem2s (#260) * Rename pipeline status updates redux setup to backend status updates to better reflect the fact it is showing state of worker, pipeline and gem2s * Change redux store pipelineStatus property to backendStatus to more accurately reflect what it is actually storing * Other minor renaming of loadPipelineStatus redux action and of prop taken by loading screen of gem2s * Merge status * Write state for each of backend services separately * Fix tests snapshots * Add tests Co-authored-by: Martin Fosco <[email protected]> * Add clonedeep to value taken from getState() (#262) Co-authored-by: Martin Fosco <[email protected]> * Remove unused file (#249) * Add end-to-end authentication and authorization (#250) * Fix authentication error in the UI for local development * Add authorization to the UI * fix linting errors * refactor amplify * remove beautiful jwt reference * fix * Log fetch errors * Extra logging * Auth fixes + logging (#263) * Logging * Do not prevent console statements * More logging * Remove circular reference created by logging * Hopefully force 401 * Redirect to data management instead of default experiment * Auth.configure only server-side * Fix tracking of amplifyConfigured * getInitialProps only if server side * Fix broken guard on getInitialProps * Remove debug logging * Remove debug logging * Less noisy logging Co-authored-by: Xavier Verges <[email protected]> * Add cognito user and admin details to rbac can write (#264) * Fix authentication error in the UI for local development * Add authorization to the UI * fix linting errors * refactor amplify * remove beautiful jwt reference * fix * Log fetch errors * Extra logging * Switch create experiment to point to new create experiment endpoint * Remove error on merge * Add post fetch test Co-authored-by: Marcell Pek <[email protected]> Co-authored-by: Marcell Pék <[email protected]> Co-authored-by: Xavier Verges <[email protected]> Co-authored-by: Martin Fosco <[email protected]> * Make checking for strings in vega canvases more robust (#253) * Load projects samples (#258) * Add new CI pipeline for merging things into develop (#225) * Add new CI pipeline for merging things into develop (#226) * changed small text to trigger rebuild (#228) * changed small text to trigger rebuild * removed duplicated ci-dev.yaml * redoing the ticket * fix * fixes * fixes * fix * fixes * fix tests * small fix Co-authored-by: Pol Alvarez <[email protected]> * Select the proper redirect url BIOMAGE-997 (#266) * Select the proper redirect url * Remove useless comments * fix checking of uploaded samples (#269) * fix checking of uploaded samples * change to check for null * fix description bug * Load experiments (#272) * load experiments * map experiment object * throw error if fetch causes error * [BIOMAGE-1000] bad url handling to get the organism list (#268) * Different treatment for api and non api urls * Keep linter happy * Rename file * Clarify metadata showing unfiltered cell numbers (#270) * Handle gem2s response (#274) * Handle status updates * Fix tests (they rely on steps prop) * Remove unused steps prop * Fix tests Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Xavier Verges <[email protected]> * Fix loading logic of "new project" dialog * Fix authentication for projects [BIOMAGE-1006] (#267) * prevent create project if failed * fix json no body error * Increased the timeout for one violin plot test * We are not using fetchMock properly! Co-authored-by: Xavier Verges <[email protected]> * Revert "Fix loading logic of "new project" dialog" (#276) This reverts commit 43a9acf. * move call to backend status (#275) * Update project metadata (#261) * Updates to metadata name reflected in projects * Saving metadata saves to database * Address comments pr 272 (#273) * address comments * create tests for load experiments * fix ids accumulation, add test * Delete project delete experiment [BIOMAGE-948] (#279) * create experimentsDeleted actionType * fix bug deleting experiment ids * add reducer test * Prevent re-run pipeline if succeeded [BIOMAGE-1007] (#278) * rename pipelineStatus to pipelineStatusValues * display project uuid (#280) * [BIOMAGE-1002] Remove delay from Project Name validation (#282) * Validate project name inside useEffect * Removed failed attempt of clearing * Removed comment * [BIOMAGE-1012] - Prevent repeating notifications (#281) * add default push notification clear message time * remove notification manager * change push notification dispatches to fn calls * remove notification redux * remove error time for messages * not reloading experiments for old experiments without project UUID (#283) * Fix transition between gem2s and data processing (#277) * Fix various bugs * Wrong prop types Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Xavier Verges <[email protected]> * [BIOMAGE-1024] - Fix long project name hiding project controls (#284) * remove from title to normal description item * align buttons to the top * fix long project names in main area * stick "create new project" on top of list * new project modal state set as closed to avoid fluttering in & out (#286) * [BIOMAGE-1023] - Relaunch experiment from GEM2S error screen (#287) * relaunch experiment from GEM2S error screen * update last analyzed (#291) * Show data processing after qc is running (#295) * Remove qc update when the message received is an error (#289) Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> * Fix delete project showing error that should not appear (#297) * Move select action to before other updates in redux * Fix tests * Add filter to avoid reselecting delected project if it is first in list Co-authored-by: Martin Fosco <[email protected]> * validate metadata track name (#299) * validate metadata track name * only allow space in metadata name * more valid validation * [BIOMAGE-885] - Filter cells out of plot (#292) * [BIOMAGE-1045] Issues with launching metadata (#298) * fix * fix-tests * Disable dash metadata track (#302) * change from dash to underscore * fix metadata validation * [BIOMAGE-1041] The UI still shows the old experiment when a user launches a new experiment (#301) * Add new CI pipeline for merging things into develop (#225) * Add new CI pipeline for merging things into develop (#226) * changed small text to trigger rebuild (#228) * changed small text to trigger rebuild * removed duplicated ci-dev.yaml * fixes * fix * rework * fix tests * fix Co-authored-by: Pol Alvarez <[email protected]> * [BIOMAGE-963] - Add species metadata input (#296) * [BIOMAGE-989] - Work request throw error if pipeline has not yet succeeded (#300) * change sendWork to use fetchCachedWork * pass backendstatus to fetchcachedgene * [BIOMAGE-1026] Improved error messages (#290) * Common fetch error + user messages + await on dispatch * Address PR comments * Remove new awaits on dispatches (#305) Co-authored-by: Martin Fosco <[email protected]> * new flow for releases (#306) * added deployment for release/hotfixes PRs to master (#308) * adding new flow actions to master as a hotfix (#310) (#311) Co-authored-by: Pol Alvarez <[email protected]> * using tokens to allow flow to trigger testing * [BIOMAGE-760] - Show login screen if user is unauthenticated (#304) * Update ci-develop.yaml * update doublet score info (#303) * update doublet score info * update text * more pithy * update text based on Vicky's comment * add for each sample * wrong use of rest parameters (#321) * Update ci-develop.yaml * Update ci-develop.yaml * Delete files in s3 for deleted samples (#318) * Remove samples unnecessary ids field * Fix error on trying to decode a non json * Update DELETE call * Fix tests * Fix * Add cancel set up without the actual call for amplify * Fix delete files refactoring * Null upload promise on completion * Add missing nulls for amplify promises * Fix tests * Add source for flushPromises * Clean up comments * Remove commented line Co-authored-by: Martin Fosco <[email protected]> * Add await back (#327) Co-authored-by: Martin Fosco <[email protected]> * receiving notification from API on work-response (#328) * wip receiving notification from API on work-response * Add small comments and comment out dispatch(saveCellSets(experimentId)); * removed unused import * removed async * clean up Co-authored-by: Martin Fosco <[email protected]> * [BIOMAGE-1044] Add a needsRunning flag to gem2s pipeline status (#319) * Use the needsRunning flag of gem2s status before launching it * Disable launch button after it is clicked * Refactoring and fix issue with taskparams hash * Fix tests and minor bugfixes of experiments reducer Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> * [BIOMAGE-1109] Fix metadata not saving (#329) * Remove no longer used sample ids and remove properties that aren't samples from the updates * Remove samples extra loading * Fix tsts * Fix * User profile change details (#293) * Add new CI pipeline for merging things into develop (#225) * Add new CI pipeline for merging things into develop (#226) * changed small text to trigger rebuild (#228) * changed small text to trigger rebuild * removed duplicated ci-dev.yaml * changes * changes * fix * fix * fixes * change regular expression * cancel button * changes * email disabled error improvement * update * start workflow * changes Co-authored-by: Pol Alvarez <[email protected]> * Send redux disaptch action in correct shape (#332) Co-authored-by: ogibson <[email protected]> Co-authored-by: Anugerah Erlaut <[email protected]> Co-authored-by: Xavier Vergés <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Juanlu <[email protected]> Co-authored-by: ogibson-biomage <[email protected]> Co-authored-by: Oliver Gibson <[email protected]> Co-authored-by: Marcell Pék <[email protected]> Co-authored-by: Marcell Pek <[email protected]> Co-authored-by: StefanBabukov <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Pickering <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: ogibson <[email protected]> * Deprecated check in ci.yaml Co-authored-by: Anugerah Erlaut <[email protected]> Co-authored-by: Xavier Vergés <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: Juanlu <[email protected]> Co-authored-by: ogibson-biomage <[email protected]> Co-authored-by: Oliver Gibson <[email protected]> Co-authored-by: Marcell Pék <[email protected]> Co-authored-by: Marcell Pek <[email protected]> Co-authored-by: StefanBabukov <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alex Pickering <[email protected]> Co-authored-by: Martin Fosco <[email protected]> Co-authored-by: ogibson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Link to issue
Link to staging deployment URL
Links to any Pull Requests related to this
Anything else the reviewers should know about the changes here
There was a bug in metadata tracks when setting up two samples, the same value set for one metadata track in a sample would be applied to the other sample's track.
Changes
Code changes
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing
To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?
Approvers
Just before merging:
unstagescript in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to stagingOptional